Tests cleanup#141
Conversation
| } | ||
| ``` | ||
|
|
||
| Build & run: |
There was a problem hiding this comment.
Tests alone can't be built right?
I believe these steps is to build URM
There was a problem hiding this comment.
yes I will update the readme.
|
|
||
| --- | ||
|
|
||
| ## CTest Integration |
There was a problem hiding this comment.
Is CTest part of mini test frameowork ?
There was a problem hiding this comment.
ctest is tool that runs the tests
There was a problem hiding this comment.
Are we able to run CTest on device ?
|
|
||
| #include "Timer.h" // your Timer component | ||
| #include "Timer.h" // Timer component | ||
| #include "ThreadPool.h" // whatever defines ThreadPool |
There was a problem hiding this comment.
Can you please delete "// whatever defines ThreadPool"
Also do we need any comment/explanation for header files? if needed let's have one-liner about the header
There was a problem hiding this comment.
Can we add an appropriate tag instead of component-serial ?
There was a problem hiding this comment.
Can we change the tag component-serial ?
There was a problem hiding this comment.
--> TAP v13 for CI
what is TAP v13 referred to ?
There was a problem hiding this comment.
TAP v13 is just a way for test programs to print their results in a standard format .
|
|
||
| --- | ||
|
|
||
| ## Quick Start |
There was a problem hiding this comment.
Suggestion... We can change Examples instead of Quick Start
Also provide more exampled for Fixtures, Parameterized tests, expected failures XFAIL etc
| // Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | ||
| // SPDX-License-Identifier: BSD-3-Clause-Clear | ||
|
|
||
| #ifndef MINI_HPP_INCLUDED |
There was a problem hiding this comment.
There are some unused macros in this file, better to remove them since it is already quite large.
I had identified and removed some of them https://github.com/qualcomm/userspace-resource-manager/pull/129/files#diff-87b5f1d2f7d578e71739d488377fce417ca98ccd67cd5af6382e7b1c10c46b46L405
But while merging one of the pr's they got mistakenly reinstated. Could you check if they can be removed.
There was a problem hiding this comment.
We need some of them like marker and Fixture parameterized test macro. I will remove list
|
|
||
| #include "TestUtils.h" // if your tests rely on helpers/macros | ||
| #include "TestUtils.h" // tests rely on helpers/macros | ||
| #include "ThreadPool.h" // your thread pool component |
There was a problem hiding this comment.
don't really need these comments here
| // SPDX-License-Identifier: BSD-3-Clause-Clear | ||
|
|
||
| #include "../../../resource-tuner/core/Include/ResourceRegistry.h" | ||
| #include "../../../resource-tuner/core/Include/TargetRegistry.h" |
There was a problem hiding this comment.
I think this can be avoided, if we just link the lib / exec building unit tests to libRestuneCore, as we are doing for ParserTests.cpp I think
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…-manager into tests-cleanup
5 participants
Added License.