Add ML-based contextual classification tests with YAML config and integration tests#194
Merged
Merged
Conversation
Signed-off-by: varusing <varusing@qti.qualcomm.com>
Signed-off-by: varusing <varusing@qti.qualcomm.com>
Signed-off-by: varusing <varusing@qti.qualcomm.com>
…egration tests Signed-off-by: varusing <varusing@qti.qualcomm.com>
kartnema
reviewed
Feb 26, 2026
|
|
||
| // Assert that model file exists and is accessible (size > 0) | ||
| E_ASSERT((modelExists > 0)); | ||
| }) |
Contributor
There was a problem hiding this comment.
We can add more tests here for testing if node-configurations are affected or not, for simple apps like vi with per-app configs
kartnema
reviewed
Feb 26, 2026
| UrmExtAPIs | ||
| RestuneCore | ||
| RestuneTestUtils) | ||
| target_link_libraries(UrmComponentTests PUBLIC UrmAuxUtils |
Contributor
There was a problem hiding this comment.
We'll need to add build gates so that only resource-tuner tests are built if classifier is not enabled
kartnema
reviewed
Feb 26, 2026
| std::cout << LOG_BASE << "Inference created successfully" << std::endl; | ||
|
|
||
| // Test result counters | ||
| int passed = 0; |
kartnema
reviewed
Feb 26, 2026
| * - Handles missing executables gracefully (marked as SKIPPED) | ||
| * - Provides detailed logging for debugging classification failures | ||
| * Cross-Reference: Comprehensive application classification validation | ||
| */ |
…egration tests Signed-off-by: varusing <varusing@qti.qualcomm.com>
kartnema
reviewed
Mar 3, 2026
|
|
||
| install(TARGETS UrmComponentTests DESTINATION ${CMAKE_INSTALL_BINDIR}) | ||
|
|
||
| add_executable(UrmIntegrationTests Integration/IntegrationTests.cpp Integration/CCIntegrationTest.cpp) |
Contributor
There was a problem hiding this comment.
we can add a classifier build gate here as well, i.e.
only adding Integration/CCIntegrationTest.cpp if BUILD_CLASSIFIER is enabled
…egration tests Signed-off-by: varusing <varusing@qti.qualcomm.com>
…egration tests Signed-off-by: varusing <varusing@qti.qualcomm.com>
kartnema
approved these changes
Mar 3, 2026
Signed-off-by: Varun Singhal <varusing@qti.qualcomm.com>
…egration tests Signed-off-by: varusing <varusing@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRs-Fixed: 4452126