Skip to content

Feature/topic scoping#26

Merged
drorIvry merged 3 commits into
mainfrom
feature/topic-scoping
Jan 29, 2026
Merged

Feature/topic scoping#26
drorIvry merged 3 commits into
mainfrom
feature/topic-scoping

Conversation

@drorIvry

@drorIvry drorIvry commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

Summary by CodeRabbit

  • New Features

    • Added topic scoping configuration options to evaluation requests, enabling control over scoping mode, multi-turn behavior, and policy targets.
  • Chores

    • Version bumped to 1.5.1.
    • Updated development environment ignore rules.
  • Tests

    • Added test coverage for topic scoping payload serialization in evaluation requests.

✏️ Tip: You can customize this high-level summary in your review settings.

drorIvry and others added 3 commits January 28, 2026 22:58
Support topicScopingMode, topicScopingMultiTurnMode, and topicScopingTarget
in both framework and direct evaluation modes.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
# Conflicts:
#	package.json
#	src/index.ts
@coderabbitai

coderabbitai Bot commented Jan 28, 2026

Copy link
Copy Markdown

Walkthrough

These changes add topic scoping configuration support to evaluation request payloads by introducing new schema fields (topicScopingMode, topicScopingMultiTurnMode, topicScopingTarget) to both EvaluationRequestV2 and EvaluationProxyAPIRequest types, extending request payload construction to include these fields, and validating serialization through new test cases. Package version is incremented to 1.5.1.

Changes

Cohort / File(s) Summary
Version & ignore configuration
.gitignore, package.json
Added .DS_Store to ignore list; bumped package version from 1.5.0 to 1.5.1
Schema definitions
src/types.ts
Added topic scoping fields to EvaluationRequestV2Schema (topicScopingMode, topicScopingMultiTurnMode, topicScopingTarget) and corresponding snake_case/camelCase variants to EvaluationProxyAPIRequestSchema with optional defaults
Request payload construction
src/index.ts
Extended both backward-compatibility and converter code paths to include topic scoping fields derived from source request objects in evaluation API payloads
Validation tests
test/index.spec.ts
Added "topic scoping fields" test suite with cases validating correct serialization of topic scoping parameters in both direct and framework modes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 New fields hop into the schemas today,
Topic scoping guides evaluation's way,
From camelCase to snake, both paths align,
Tests verify the payload shines so fine!
Version bumps, and .DS_Store stays away. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Feature/topic scoping' is partially related to the changeset, referring to the main feature being added, but uses a generic prefix format rather than a clear, descriptive summary of the change. Improve the title to be more descriptive and specific, such as 'Add topic scoping fields to evaluation requests' to clearly convey what the feature entails.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/topic-scoping

Comment @coderabbitai help to get the list of available commands and usage tips.

@drorIvry drorIvry merged commit 9106dc3 into main Jan 29, 2026
3 checks passed
@drorIvry drorIvry deleted the feature/topic-scoping branch January 29, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants