Skip to content

Feature - new apis #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drorIvry merged 3 commits into from
Feb 3, 2026
Merged

Feature - new apis #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
336646b
feat: feat
drorIvry Feb 1, 2026
0c6bc04
feat: fix
drorIvry Feb 1, 2026
7c0c1af
feat: wip
drorIvry Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "qualifire",
"version": "1.6.0",
"version": "1.7.0",
"description": "Qualifire client SDK",
"main": "./lib/index.js",
"files": [
Expand Down
36 changes: 29 additions & 7 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
EvaluationRequestV2Schema,
type EvaluationResponse,
type Framework,
type LLMMessage,
} from './types';

export type {
Expand Down Expand Up @@ -44,7 +45,7 @@ export class Qualifire {
constructor({ apiKey, baseUrl }: { apiKey?: string; baseUrl?: string }) {
const key = apiKey || process.env.QUALIFIRE_API_KEY;
const qualifireBaseUrl =
baseUrl || process.env.QUALIFIRE_BASE_URL || 'https://proxy.qualifire.ai';
baseUrl || process.env.QUALIFIRE_BASE_URL || 'https://api.qualifire.ai';

if (!key) {
throw new Error(
Expand All @@ -59,8 +60,11 @@ export class Qualifire {
init(): void {
process.env.TRACELOOP_TELEMETRY = 'false';

const tracingBaseUrl =
process.env.QUALIFIRE_TRACING_URL || 'https://tracing.qualifire.ai';

traceloop.initialize({
baseUrl: `${this.baseUrl}/api/telemetry`,
baseUrl: `${tracingBaseUrl}/api/telemetry`,
headers: {
'X-Qualifire-API-Key': this.sdkKey,
},
Expand Down Expand Up @@ -234,7 +238,7 @@ export class Qualifire {
evaluationProxyAPIRequest.sexual_content_check ||
evaluationProxyAPIRequest.sexualContentCheck;

const url = `${this.baseUrl}/api/evaluation/evaluate`;
const url = `${this.baseUrl}/api/v1/evaluation/evaluate`;
const body = {
input: evaluationProxyAPIRequest.input,
output: evaluationProxyAPIRequest.output,
Expand Down Expand Up @@ -266,6 +270,14 @@ export class Qualifire {
tuq_mode:
evaluationProxyAPIRequest.tuqMode ?? evaluationProxyAPIRequest.tsqMode,
assertions: evaluationProxyAPIRequest.assertions,
assertions_mode: evaluationProxyAPIRequest.assertionsMode,
hallucinations_mode: evaluationProxyAPIRequest.hallucinationsMode,
grounding_mode: evaluationProxyAPIRequest.groundingMode,
grounding_multi_turn_mode:
evaluationProxyAPIRequest.groundingMultiTurnMode,
policy_multi_turn_mode: evaluationProxyAPIRequest.policyMultiTurnMode,
policy_target: evaluationProxyAPIRequest.policyTarget,
allowed_topics: evaluationProxyAPIRequest.allowedTopics,
Comment on lines 271 to +280

@coderabbitai coderabbitai Bot Feb 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Propagate new policy mode fields to converter-based requests.
These fields are only sent in the backward-compat path, so EvaluationRequestV2 callers using converters won’t send them. Consider adding them to the converter payload as well.

➕ Suggested fix 
       tuq_mode: EvaluationRequestV2.tuqMode ?? EvaluationRequestV2.tsqMode,
       assertions: EvaluationRequestV2.assertions,
+      assertions_mode: EvaluationRequestV2.assertionsMode,
+      hallucinations_mode: EvaluationRequestV2.hallucinationsMode,
+      grounding_mode: EvaluationRequestV2.groundingMode,
+      grounding_multi_turn_mode: EvaluationRequestV2.groundingMultiTurnMode,
+      policy_multi_turn_mode: EvaluationRequestV2.policyMultiTurnMode,
+      policy_target: EvaluationRequestV2.policyTarget,
       topic_scoping_mode: EvaluationRequestV2.topicScopingMode,
🤖 Prompt for AI Agents 
In `@src/index.ts` around lines 268 - 277, The converter-based path for
EvaluationRequestV2 is missing propagation of new policy fields
(policy_multi_turn_mode, policy_target, allowed_topics and the other
policy/grounding/assertion mode fields) from evaluationProxyAPIRequest; update
the converter payload construction used by EvaluationRequestV2 to include the
same mappings as the backward-compat path (e.g., map
evaluationProxyAPIRequest.policyMultiTurnMode -> policy_multi_turn_mode,
policyTarget -> policy_target, allowedTopics -> allowed_topics, and likewise for
assertions_mode, hallucinations_mode, grounding_mode, grounding_multi_turn_mode)
so converter callers send the new fields as well.

topic_scoping_mode:
evaluationProxyAPIRequest.topicScopingMode ??
evaluationProxyAPIRequest.topic_scoping_mode,
Expand Down Expand Up @@ -340,7 +352,7 @@ export class Qualifire {
EvaluationRequestV2.response
);

const url = `${this.baseUrl}/api/evaluation/evaluate`;
const url = `${this.baseUrl}/api/v1/evaluation/evaluate`;
const body = {
messages: evaluationRequest.messages,
available_tools: evaluationRequest.available_tools,
Expand Down Expand Up @@ -407,18 +419,28 @@ export class Qualifire {
input,
output,
evaluationId,
messages,
availableTools,
metadata,
}: {
input: string;
output: string;
input?: string;
output?: string;
evaluationId: string;
messages?: LLMMessage[];
availableTools?: Array<{
name: string;
description?: string;
parameters?: Record<string, unknown>;
}>;
metadata?: Record<string, string>;
}): Promise<EvaluationResponse | undefined> => {
const url = `${this.baseUrl}/api/evaluation/invoke`;
const url = `${this.baseUrl}/api/v1/evaluation/invoke`;
const body = JSON.stringify({
input,
output,
evaluation_id: evaluationId,
messages,
available_tools: availableTools,
metadata,
});

Expand Down