Skip to content

feature/assertions tools support FIRE 1094#29

Merged
drorIvry merged 1 commit into
mainfrom
feature/assertions-tools-support-FIRE-1094
Feb 10, 2026
Merged

feature/assertions tools support FIRE 1094#29
drorIvry merged 1 commit into
mainfrom
feature/assertions-tools-support-FIRE-1094

Conversation

@drorIvry

@drorIvry drorIvry commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

Summary by CodeRabbit

  • New Features

    • Enhanced policy evaluation with new configuration options: ability to include or exclude tools from policy evaluation, control assertion modes, enable multi-turn policy evaluation, and specify policy targets.
  • Chores

    • Version bumped to 1.8.0.
    • Added test coverage for new policy configuration features.

@coderabbitai

coderabbitai Bot commented Feb 9, 2026

Copy link
Copy Markdown

Walkthrough

Version bump from 1.7.0 to 1.8.0 with addition of policyIncludeTools field to evaluation request schemas, request wiring in both backward-compatibility and converter paths, and corresponding test coverage.

Changes

Cohort / File(s) Summary
Version Update
package.json
Bumped version from 1.7.0 to 1.8.0.
Schema Definitions
src/types.ts
Added policyIncludeTools boolean field with default false to both EvaluationRequestV2Schema and EvaluationProxyAPIRequestSchema.
Request Wiring
src/index.ts
Mapped policyIncludeTools from request objects to API request payloads in both backward-compatibility and converter paths, propagating the field to evaluation request bodies.
Test Coverage
test/index.spec.ts
Added test suite "policy_include_tools field" with tests verifying that policy_include_tools: true appears in API request bodies for both direct and framework evaluation modes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • amos-qualifire
  • yuval-qf
  • osher-qualifire

Poem

🐰 Tools and policies unite,
Schemas bloom with new delight,
Version springs from one-point-seven,
Tests confirm the feature's heaven!
Include them all, in tools we trust

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'feature/assertions tools support FIRE 1094' is partially related to the changeset. The title mentions 'assertions tools support' but the actual changes focus on adding 'policyIncludeTools' field support across schemas, types, and tests, which is broader than just assertions. The title is somewhat vague and doesn't clearly reflect the primary technical change. Revise the title to more specifically describe the main change, such as 'Add policyIncludeTools field support to evaluation requests' or 'Support policy tool inclusion in evaluation API'. This would better reflect the actual implementation details.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/assertions-tools-support-FIRE-1094

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@drorIvry drorIvry requested a review from yuval-qf February 9, 2026 16:02

@yuval-qf yuval-qf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drorIvry drorIvry merged commit c2d2ad4 into main Feb 10, 2026
3 checks passed
@drorIvry drorIvry deleted the feature/assertions-tools-support-FIRE-1094 branch February 10, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants