Skip to content

hotfix/cli with server support python protocol#172

Merged
drorIvry merged 3 commits into
mainfrom
hotfix/cli-with-server-support-python-protocol
Apr 29, 2026
Merged

hotfix/cli with server support python protocol#172
drorIvry merged 3 commits into
mainfrom
hotfix/cli-with-server-support-python-protocol

Conversation

@yuval-qf
Copy link
Copy Markdown
Collaborator

  • Fix python protocol bug in cli, Add --with-server to cli
  • bump version

Description

Motivation and Context

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Code style/refactoring (no functional changes)
  • 🧪 Test updates
  • 🔧 Configuration/build changes

Changes Made

Screenshots/Examples (if applicable)

Checklist

  • I have read the CONTRIBUTING.md guide
  • My code follows the code style of this project (PEP 8, type hints, docstrings)
  • I have run uv run black . to format my code
  • I have run uv run flake8 . and fixed all issues
  • I have run uv run mypy --config-file .mypy.ini . and addressed type checking issues
  • I have run uv run bandit -c .bandit.yaml -r . for security checks
  • I have added tests that prove my fix is effective or that my feature works
  • I have run uv run pytest and all tests pass
  • I have manually tested my changes
  • I have updated the documentation accordingly
  • I have added/updated type hints for new/modified functions
  • My changes generate no new warnings
  • I have checked my code for security issues
  • Any dependent changes have been merged and published

Testing

Test Configuration:

  • Python version:
  • OS:
  • Other relevant details:

Test Steps:
1.
2.
3.

Additional Notes

Related Issues/PRs

  • Fixes #
  • Related to #
  • Depends on #

@yuval-qf yuval-qf requested a review from drorIvry as a code owner April 29, 2026 12:16
@yuval-qf yuval-qf self-assigned this Apr 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Caution

Review failed

Pull request was closed or merged during review

Summary by CodeRabbit

  • New Features

    • Added optional --with-server flag to CLI mode for automatic background server startup.
  • Chores

    • Version updated to 0.6.4.
    • Updated test scenarios and execution configuration.

Walkthrough

Configuration updates shift the rogue testing framework from an HTTP-based shirtify assistant to a Python-based echo agent, with modified scenario definitions and execution protocol. CLI mode now supports optional background server startup. Type validation enhancements enforce protocol-specific transport constraints. Project version incremented to 0.6.4.

Changes

Cohort / File(s) Summary
Configuration Updates
.rogue/scenarios.json, .rogue/user_config.json
Scenario definitions rewritten to model echo agent instead of shirtify assistant; execution protocol switched from a2a to python with new python_entrypoint_file path; scan_type changed from basic to custom; transport setting removed.
Version Bump
VERSION
Project version incremented from 0.6.3 to 0.6.4.
CLI Server Integration
rogue/__main__.py
Added optional --with-server flag for CLI mode to start background rogue server; implements local HTTP URL construction with IPv6 and 0.0.0.0 normalization; manages server process lifecycle with try/finally cleanup.
Type Validation
sdks/python/rogue_sdk/types.py
Updated AgentConfig.transport type annotation to `Transport

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • drorIvry

Poem

🐰 Hop-hop, the config now echoes with Python's grace,
No more HTTP shirtify in this place,
Servers start in the background, cleanup on cue,
Transport validation keeps protocols true—
Version bumps forward, 0.6.4 in sight! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete, missing critical sections like Motivation, Type of Change selection, Changes Made details, Testing steps, and Related Issues—only bullet points are filled. Complete the description by filling in Motivation/Context, selecting Type of Change checkbox(es), listing specific changes, describing test steps, and linking related issues.
Docstring Coverage ⚠️ Warning Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'hotfix/cli with server support python protocol' is related to the main changes but is somewhat unclear and uses a branch-naming convention rather than a concise PR summary format. Revise the title to be more concise and descriptive, e.g., 'Add --with-server flag to CLI and fix Python protocol validation' or 'Fix Python protocol bug and add server support to CLI'.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/cli-with-server-support-python-protocol

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@drorIvry drorIvry enabled auto-merge (squash) April 29, 2026 12:17
@drorIvry drorIvry merged commit f4f0e78 into main Apr 29, 2026
8 checks passed
@drorIvry drorIvry deleted the hotfix/cli-with-server-support-python-protocol branch April 29, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants