Skip to content

Commit 3f6437c

Browse files
committed
Fix manifest
1 parent 44c9f2f commit 3f6437c

3 files changed

Lines changed: 15 additions & 11 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22
edition = "2024"
33
name = "rops"
4-
version = "0.5.0"
4+
version = "0.5.1"
55

66
[dependencies]
77
base64 = "0.22.1"

src/docker.rs

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ fn _default_docker_image_repo_url() -> String {
3636
fn _default_docker_git_sha_arg() -> Option<String> {
3737
get_default_from_env("DOCKER_GIT_SHA_ARG", None)
3838
}
39-
4039
#[derive(clap::Subcommand, Debug, Clone)]
4140
pub enum DockerCommand {
4241
/// Build a new Docker image
@@ -87,14 +86,13 @@ impl DockerCommand {
8786
}
8887

8988
// Prepare the Docker build command
89+
// Disable DOCKER_BUILDKIT to avoid manifest list creation with attestations
9090
let mut command = Command::new("docker");
9191
command
92-
.env("DOCKER_BUILDKIT", "1") // Enable Docker BuildKit
92+
.env("DOCKER_BUILDKIT", "0") // Disable BuildKit to avoid attestations
9393
.arg("build")
9494
.arg("-f")
9595
.arg(&dockerfile)
96-
.arg("--platform")
97-
.arg(settings.system.to_string())
9896
.arg("-t")
9997
.arg(&image_name);
10098

@@ -121,7 +119,6 @@ impl DockerCommand {
121119

122120
let mut command = Command::new("docker");
123121
command
124-
.env("DOCKER_BUILDKIT", "1") // Enable Docker BuildKit
125122
.arg("tag")
126123
.arg(&image_name) // Correct image name
127124
.arg(&tag);
@@ -135,8 +132,7 @@ impl DockerCommand {
135132

136133
// Push all tags with --all-tags flag
137134
let mut command = Command::new("docker");
138-
command
139-
.env("DOCKER_BUILDKIT", "1") // Enable Docker BuildKit
135+
command // Disable Docker BuildKit
140136
.arg("push")
141137
.arg(&tag);
142138

@@ -150,9 +146,17 @@ impl DockerCommand {
150146
let manifest_tag = self.get_push_tag(name, false, settings);
151147
let amd64_tag = format!("{}-amd64", manifest_tag);
152148
let arm64_tag = format!("{}-arm64", manifest_tag);
153-
self.push_manifest(&manifest_tag, &amd64_tag, &arm64_tag)?;
149+
self.push_manifest(
150+
&manifest_tag,
151+
&amd64_tag,
152+
&arm64_tag,
153+
)?;
154154
if let Some(latest_tag) = self.get_latest_tag(name, settings) {
155-
self.push_manifest(&latest_tag, &amd64_tag, &arm64_tag)?;
155+
self.push_manifest(
156+
&latest_tag,
157+
&amd64_tag,
158+
&arm64_tag,
159+
)?;
156160
}
157161
Ok(())
158162
}

0 commit comments

Comments
 (0)