Pip install setup docs#2020
Conversation
| import versioneer | ||
|
|
||
|
|
||
| class LazyBuildExtCommandClass(dict): |
There was a problem hiding this comment.
Can we check for numpy/Cython being installed and fail with a clear error here if they're not?
There was a problem hiding this comment.
We should remove the setup_requires for numpy/Cython as well, since they're the main thing that causes breakage.
There was a problem hiding this comment.
Hmm, as it currently is, setup.py develop is broken. Will need to dig into it if we want to remove even more.
128b678 to
8611a5e
Compare
8611a5e to
d0d96bb
Compare
| depends=['zipline/lib/adjustment.pxd'], | ||
| ), | ||
| ] | ||
| ext_modules = [ |
There was a problem hiding this comment.
Wow, we have a lot of extensions. Probably not for this PR, but I wonder if we could consolidate these somehow. That might speed up some of our CI build times significantly I think.
There was a problem hiding this comment.
Yea, the pip install -e . of the builds takes 90+ seconds currently.
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ pip install numpy Cython |
There was a problem hiding this comment.
This will give people the latest version of numpy. Do we support that?
There was a problem hiding this comment.
AFAIK we do. If we don't, then we should update setup.py's REQ_UPPER_BOUNDS.
|
Hi @richafrank anything I can do to help get this branch merged? |
a1eff02 to
54e5c9e
Compare
54e5c9e to
bcddf4b
Compare
I think we should get agreement with the team that the install workflow changes here are what we want, and that there aren't any broken scenarios. |
|
I'm 👍 on merging these changes as-is. The only thing we might want to add to this is an entry to the release notes telling people that they need to pre-install numpy now if they're using pip. |
|
@ssanderson @richafrank should we merge once we add requirement to install numpy to release notes (per Scott's comment^)? |
6 participants
From #2016 (comment)