Consolidate state tomography implementations#8192
Draft
arettig wants to merge 3 commits into
Draft
Conversation
…entation The one and two qubit specialized state tomography within qubit_characterization.py is changed to use the n_qubit_tomography implementation as the backend.
Use uuid to generate a unique measurement key name when running state tomography to ensure no collisions occur with existing measurement keys in the circuit.
Moves TomographyResult definition and plotting helper functions to n_qubit_tomography.py to avoid circular imports.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8192 +/- ##
==========================================
- Coverage 99.60% 99.59% -0.01%
==========================================
Files 1118 1118
Lines 101349 101307 -42
==========================================
- Hits 100945 100896 -49
- Misses 404 411 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2737 (part 2/2, #8191 should be merged first)
Removes the specialized implementations of one and two qubit state tomography, running them instead through the n-qubit state tomography. There are several cleanup changes as a result of this:
TomographyResultis moved ton_qubit_tomography.py. This avoids circular dependency and is more appropriate now that this is the only tomography implementation.