From 48a537c12a5344b5e977040025913c4dca20a27d Mon Sep 17 00:00:00 2001 From: mhucka Date: Sun, 5 Apr 2026 17:58:50 +0000 Subject: [PATCH 1/3] Don't use indent size = 4 for Makefiles --- .editorconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index e11d23203..7da5d899a 100644 --- a/.editorconfig +++ b/.editorconfig @@ -38,7 +38,6 @@ indent_size = 4 [{Makefile,makefile,*.mk}] indent_style = tab -indent_size = 4 [{*.cc,*.h}] indent_size = 2 From b7985f0f7d7871b9115b3ed613f553a95a41e13e Mon Sep 17 00:00:00 2001 From: mhucka Date: Sun, 5 Apr 2026 23:13:41 +0000 Subject: [PATCH 2/3] Explicitly set tab_width = 8 Although tabs usually default to 8 columns, people who set their editors to a different value for the tab width may see different indentation in project files unless we explicitly specify a tab width of 8 in `.editorconfig`. --- .editorconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index 7da5d899a..85b1dc00a 100644 --- a/.editorconfig +++ b/.editorconfig @@ -23,9 +23,10 @@ root = true charset = utf-8 indent_style = space insert_final_newline = true +max_line_length = 80 spelling_language = en-US +tab_width = 8 trim_trailing_whitespace = true -max_line_length = 80 [{BUILD,*.BUILD,*.bzl,*.bazel,.bazelrc,WORKSPACE}] indent_size = 4 From 2d065b542c51ed352390e1f8ccec4fa02a36c63e Mon Sep 17 00:00:00 2001 From: Michael Hucka Date: Tue, 7 Apr 2026 10:59:18 -0700 Subject: [PATCH 3/3] Only set tab_width for makefiles --- .editorconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index 85b1dc00a..4636c2f04 100644 --- a/.editorconfig +++ b/.editorconfig @@ -25,7 +25,6 @@ indent_style = space insert_final_newline = true max_line_length = 80 spelling_language = en-US -tab_width = 8 trim_trailing_whitespace = true [{BUILD,*.BUILD,*.bzl,*.bazel,.bazelrc,WORKSPACE}] @@ -39,6 +38,7 @@ indent_size = 4 [{Makefile,makefile,*.mk}] indent_style = tab +tab_width = 8 [{*.cc,*.h}] indent_size = 2