Add bazel statements needed for pybind11 and export common.h#23
Merged
Conversation
noajshu
approved these changes
May 19, 2025
noajshu
left a comment
Contributor
There was a problem hiding this comment.
LGTM, could I suggest the alternate name tesseract_decoder?
|
|
||
|
|
||
| pybind_extension( | ||
| name = "tesseract_py", |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| name = "tesseract_py", | |
| name = "tesseract_decoder", |
Contributor
Author
There was a problem hiding this comment.
done ... I also changed the names of the pybind11 files to match the convention used by stem
Contributor
Author
|
@noajshu I don't have permission to merge |
Collaborator
Oh thanks for mentioning this @NoureldinYosri ! It should be fixed now, please let me know if you had any other issues! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
WORKSPACEto include the statements needed for pybind11pybind_extensionandpy_librarythat will wrap tesseractcommon.hthis is the first of a series of PRs for #17
To check this code you can create a python file
tmp.pyand add a build rule
$ bazel run src:tmp Symptom{D1 D2 }