fix issue #258: guard error_chain_arena.reserve() against SIZE_MAX pqlimit#262
Merged
Conversation
noajshu
approved these changes
Jun 15, 2026
noajshu
left a comment
noajshu
left a comment
Contributor
There was a problem hiding this comment.
Thank you, this is indeed an important edge case!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #258
When
--pqlimitis not specified, it defaults tostd::numeric_limits<size_t>::max()(SIZE_MAX). Calling
vector::reserve(SIZE_MAX)exceeds the vector's max_size()and throws std::length_error, crashing the process.
Fix by only calling reserve() when pqlimit is a finite (non-SIZE_MAX) value.