Conversation
|
🙈 The PR is closed and the preview is expired. |
cescoffier
approved these changes
May 26, 2026
maxandersen
requested changes
May 26, 2026
maxandersen
left a comment
maxandersen
left a comment
Member
There was a problem hiding this comment.
Looks good. Just a suggestion to make text less ambiguous in places.
|
|
||
| == Differences from Project Leyden | ||
|
|
||
| While both PGO and Leyden use profiling to improve performance, they solve different problems: |
Member
There was a problem hiding this comment.
Am I missing something but it's two different flags, right ?
Or is there a single flag that will pick the right strategy based on what approach you are building?
Contributor
Author
There was a problem hiding this comment.
You mean on how to enable it? If so, then yes. The idea of this section is just to give a high level overview of the differences because with all this new stuff, people are bound to be confused
Contributor
Author
|
@maxandersen anything else on your side? |
Co-authored-by: Max Rydahl Andersen <manderse@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.