Commit 26ff5a3
committed
Fix commonmark regression test to check the FileId it actually protects
roborev review (job 1730) caught that commonmark_reader_source_context_uses_forward_slashes
asserted FileId(0), but ASTContext::with_filename populates FileId(0)
internally before commonmark::read's own add_file call ever runs — the
entry that call actually writes is FileId(1). The test passed regardless
of whether that call normalized its filename, giving zero protection for
the fix in f5a93fa. Verified by reverting just that one line and
confirming the test still passed; asserting FileId(1) instead now fails
correctly when reverted.1 parent f5a93fa commit 26ff5a3
1 file changed
Lines changed: 7 additions & 2 deletions
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
105 | 110 | | |
106 | 111 | | |
107 | | - | |
108 | | - | |
| 112 | + | |
| 113 | + | |
109 | 114 | | |
110 | 115 | | |
0 commit comments