fix(highlight): render link/image brackets uniformly (closing ] was uncoloured)

Only the opening [ and closing ) of a link/image are queryable; the closing ] and opening ( are fused into the anonymous ]( token in target, so colouring just [/) left the closing ] a different colour. Drop the bracket captures so all link/image bracket punctuation uses the default foreground. qmd.punctuation.bracket stays a reserved legend/theme entry.

Author: shikokuchuo

claude-notes/plans/2026-06-10-monaco-tree-sitter-highlighting.md

@@ -109,11 +109,21 @@ Braid epic: **bd-t4ezufyg**. Sub-strands: Phase 0 `bd-mawltv3x`, Phase 1
   to gain the same innermost-wins flatten as the native path, or browser and
   native render user-grammar code blocks differently — now true parity (bd-98k6
   fixed on the browser render path too).
-  - **Not verified headlessly (flagged):** the Phase-8 *manual browser check*
-    (open a `.qmd`, eyeball the three zones, code-cell↔preview colour parity, no
-    flash/flicker, `.ts` colours unchanged) needs a running hub + browser. The
-    Monarch base's runtime tokenization and the theme's visual colours are only
-    validated by that check; everything mechanically testable is green.
+  - **Manual browser check — PASSED (2026-06-16).** Confirmed in a real
+    hub-client + local hub server session: `.qmd` editor shows the tree-sitter
+    semantic highlighting, "definitely an improvement" over the old markdown
+    mapping. (Gotcha hit en route: the **browser** was serving a cached old WASM
+    — a hard refresh / cache clear after `npm run build:wasm` was needed, on top
+    of `npm run dev:fresh`.) Minor visual **tweaks** noted by the user as
+    follow-up (palette / specific scopes), not blockers.
+  - **Tweak (2026-06-16): link/image brackets uniform.** The opening `[` was
+    coloured grey (`punctuation.bracket`) but the closing `]` was not (it is
+    fused into the anonymous `](` token inside `target`, unreachable by the
+    query), so the brackets clashed. Dropped the `[`/`)` bracket captures from
+    `highlights.scm`; all link/image bracket punctuation now renders in the
+    uniform default foreground. (`qmd.punctuation.bracket` stays a reserved
+    legend entry / theme rule for when the grammar can split `](`.) Requires a
+    WASM rebuild + browser hard-refresh.
   - **Pre-existing, unrelated failure:** `@quarto/hub-mcp`'s `hub-mcp.test.ts`
     (19/22) fails in this sandbox — `live:` tests needing an automerge server +
     MCP child-process spawn. Untouched package; orthogonal to this work.

crates/quarto-lsp-core/src/snapshots/quarto_lsp_core__tokens__tests__structural_corpus.snap

@@ -26,17 +26,13 @@ expression: rendered
 9:55-57 qmd.punctuation.special
 9:57-68 qmd.markup.raw.inline
 9:68-69 qmd.punctuation.special
-11:2-3 qmd.punctuation.bracket
 11:3-7 qmd.markup.link.label
 11:9-28 qmd.markup.link.url
 11:29-36 qmd.markup.link.title
-11:36-37 qmd.punctuation.bracket
 11:45-47 qmd.punctuation.special.image
 11:47-52 qmd.markup.image.label
 11:54-62 qmd.markup.image.url
-11:62-63 qmd.punctuation.bracket
 11:63-81 qmd.attribute.specifier
-13:2-3 qmd.punctuation.bracket
 13:15-22 qmd.attribute.specifier
 13:28-51 qmd.markup.shortcode
 15:12-19 qmd.markup.math

crates/quarto-lsp-core/src/tokens.rs

@@ -470,7 +470,10 @@ mod tests {
         let toks = tokens("[label](https://example.com)");
         assert!(has_type(&toks, "qmd.markup.link.label"), "got {toks:?}");
         assert!(has_type(&toks, "qmd.markup.link.url"), "got {toks:?}");
-        assert!(has_type(&toks, "qmd.punctuation.bracket"), "got {toks:?}");
+        // Bracket punctuation is intentionally uncoloured (uniform default):
+        // the closing `]` is unreachable by the query, so colouring only `[`
+        // looked mismatched. See highlights.scm.
+        assert!(!has_type(&toks, "qmd.punctuation.bracket"), "got {toks:?}");
     }
 
     #[test]
@@ -581,12 +584,13 @@ mod tests {
         // A 4-byte emoji before a link: the link label must start at the
         // correct UTF-16 column (emoji is 2 UTF-16 code units), not byte col.
         let toks = tokens("😀 [x](y)");
-        // "😀 " is 2 (emoji, surrogate pair) + 1 (space) = 3 UTF-16 units, so
-        // the `[` bracket sits at character 3.
+        // "😀 [" is 2 (emoji surrogate pair) + 1 (space) + 1 (`[`) = 4 UTF-16
+        // units, so the link label `x` sits at character 4 (byte offset would
+        // be 6 — emoji is 4 bytes).
         assert!(
             toks.iter()
-                .any(|t| type_name(t) == "qmd.punctuation.bracket" && t.character == 3),
-            "expected a bracket at UTF-16 char 3, got {toks:?}"
+                .any(|t| type_name(t) == "qmd.markup.link.label" && t.character == 4),
+            "expected a link label at UTF-16 char 4, got {toks:?}"
         );
     }
 

crates/tree-sitter-qmd/tree-sitter-markdown/queries/highlights.scm

@@ -47,19 +47,21 @@
 (code_span_delimiter) @punctuation.special
 
 ; --- Links (a pandoc_span is a link only when it has a `target` child) --------
+; Bracket punctuation is left uncoloured (default foreground): of `[ ] ( )`
+; only `[` and `)` are queryable — the `](` between label and url is one fused
+; anonymous token inside `target`, so `]` and `(` cannot be reached by the
+; query. Colouring only `[`/`)` made the closing `]` a different colour from
+; the opening `[`; uniform default avoids that mismatch (splitting `](` in the
+; grammar is out of scope).
 (pandoc_span (content) @markup.link.label (target))
 (pandoc_span (target (url) @markup.link.url))
 (pandoc_span (target (title) @markup.link.title))
-(pandoc_span "[" @punctuation.bracket)
 
 ; --- Images (reuse `target`; the `![` opener is one fused token) --------------
 (pandoc_image "![" @punctuation.special.image)
 (pandoc_image (content) @markup.image.label)
 (pandoc_image (target (url) @markup.image.url))
 
-; The queryable closing bracket of a link/image target.
-(target ")" @punctuation.bracket)
-
 ; --- Attribute specifiers ({#id .cls key="v"}, and code-cell {r}) -------------
 (attribute_specifier) @attribute.specifier