ci: enable Hub-Client E2E Tests workflow

The workflow had never actually run on a runner — every push to main
since it was added queued for the 24-hour GitHub Actions maximum and
was cancelled because `runs-on: ubuntu-latest-8x` isn't a runner label
this repo can request. Switching to `ubuntu-latest` unblocked
everything else; from there the workflow itself needed several layers
of fixes to actually pass:

- Runner label: ubuntu-latest-8x → ubuntu-latest.
- Build order: build the WASM module before the TypeScript packages,
  since hub-client's vite build imports the WASM JS glue.
- WASM tooling: install wasm-bindgen-cli pinned to the version in
  Cargo.lock, and add the rust-src component (required by
  -Zbuild-std=std,panic_unwind in the wasm-quarto-hub-client crate's
  .cargo/config.toml).
- Nightly pin: latest nightly rustc SIGSEGVs when compiling tokio for
  wasm32-unknown-unknown under -Zbuild-std. Pin nightly-2026-05-07 via
  the workflow's RUSTUP_TOOLCHAIN env var so rust-toolchain.toml stays
  as floating "nightly" for local developers.
- dtolnay/rust-toolchain action: dated nightlies need @master with a
  toolchain input, not @nightly-YYYY-MM-DD as a ref.
- TypeScript build scoping: only build ts-packages + hub-client. The
  q2-demos workspaces fail their vite build (vite can't resolve an
  absolute import in the wasm-bindgen output) and trace-viewer is out
  of scope. Tracked as bd-1jnb.
- Pre-build the hub binary: globalSetup launches it with `cargo run
  --bin hub` and waits 120s for "Hub server listening" — on a cold
  runner the cargo compile exceeded that.
- Baseline-commit step: switch the broken `**` glob to `find ... -name
  '*-snapshots' -exec git add -f {} +` (bash globstar isn't enabled by
  default; visual specs sit directly under hub-client/e2e/, not one
  directory deeper) and grant `contents: write` so the default
  GITHUB_TOKEN can push the auto-generated baselines back to the
  branch.
- Add a `pull_request` trigger with the same path filter as `push`,
  so PRs that touch hub-client or the workflow file have to prove
  themselves green before merging.

Author: gordonwoodhull

.github/workflows/hub-client-e2e.yml

@@ -6,6 +6,10 @@ on:
     paths:
       - 'hub-client/**'
       - '.github/workflows/hub-client-e2e.yml'
+  pull_request:
+    paths:
+      - 'hub-client/**'
+      - '.github/workflows/hub-client-e2e.yml'
   workflow_dispatch:
     inputs:
       recreate-all-snapshots:
@@ -15,10 +19,21 @@ on:
 
 jobs:
   e2e-tests:
-    runs-on: ubuntu-latest-8x
+    runs-on: ubuntu-latest
     name: Hub-Client E2E Tests
     if: github.repository == 'quarto-dev/q2'
 
+    # Needed for the "Commit new baselines" step to push back to the
+    # workflow branch. Default GITHUB_TOKEN is read-only.
+    permissions:
+      contents: write
+
+    # Pin nightly via env so we don't have to edit rust-toolchain.toml
+    # (which devs may override locally). Latest nightly currently crashes
+    # rustc with SIGSEGV when compiling tokio under -Zbuild-std for wasm32.
+    env:
+      RUSTUP_TOOLCHAIN: nightly-2026-05-07
+
     steps:
       - name: Checkout Repo
         uses: actions/checkout@v6
@@ -34,9 +49,11 @@ jobs:
 
       # Rust toolchain for WASM build
       - name: Set up Rust nightly
-        uses: dtolnay/rust-toolchain@nightly
+        uses: dtolnay/rust-toolchain@master
         with:
+          toolchain: nightly-2026-05-07
           targets: wasm32-unknown-unknown
+          components: rust-src
 
       - name: Set up Clang
         uses: egor-tensin/setup-clang@v2
@@ -51,6 +68,14 @@ jobs:
       - name: Install wasm-pack
         run: cargo install wasm-pack
 
+      # build-wasm.js verifies wasm-bindgen CLI matches the version
+      # pinned in Cargo.lock; install that exact version.
+      - name: Install wasm-bindgen-cli
+        run: |
+          VERSION=$(awk '/^name = "wasm-bindgen"$/{getline; gsub(/version = |"/, ""); print; exit}' Cargo.lock)
+          echo "Installing wasm-bindgen-cli $VERSION"
+          cargo install -f wasm-bindgen-cli --version "$VERSION"
+
       # tree-sitter for grammar builds
       - name: Set up tree-sitter CLI
         run: |
@@ -69,15 +94,32 @@ jobs:
       - name: Install npm dependencies
         run: npm ci
 
-      - name: Build TypeScript packages
-        run: npm run build
-
-      # Build WASM module
+      # WASM artifacts must exist before any package's `vite build` runs
+      # (hub-client and q2-demos/* all import the WASM module).
       - name: Build WASM
         run: |
           cd hub-client
           npm run build:wasm
 
+      # Build only the workspaces the e2e tests actually exercise.
+      # q2-demos/* currently fail their vite build (they import an
+      # absolute path "/src/wasm-js-bridge/cache.js" that only exists
+      # in hub-client/), and trace-viewer is not under test here.
+      - name: Build TypeScript packages (ts-packages + hub-client)
+        run: |
+          for pkg in ts-packages/*/; do
+            if [ -f "$pkg/package.json" ]; then
+              npm run build --workspace "$pkg" --if-present
+            fi
+          done
+          npm run build --workspace hub-client --if-present
+
+      # globalSetup launches the hub via `cargo run --bin hub` with a 120s
+      # readiness timeout. On a cold CI runner the compile alone exceeds
+      # that, so pre-build it here.
+      - name: Pre-build hub binary
+        run: cargo build --bin hub
+
       # Install Playwright browsers
       - name: Install Playwright
         run: |
@@ -112,13 +154,16 @@ jobs:
           cd hub-client
           npx playwright test --config playwright.visual.config.ts --update-snapshots=missing
 
-      # If retry passed (only missing baselines), commit them back
+      # If retry passed (only missing baselines), commit them back.
+      # Use `find` instead of a `**` glob — bash globstar isn't enabled
+      # by default and visual specs sit directly under hub-client/e2e/,
+      # not one directory deeper.
       - name: Commit new baselines
         if: steps.visual.outcome == 'failure' && steps.visual-retry.outcome == 'success'
         run: |
           git config user.name "github-actions[bot]"
           git config user.email "github-actions[bot]@users.noreply.github.com"
-          git add -f hub-client/e2e/**/*-snapshots/
+          find hub-client/e2e -type d -name '*-snapshots' -exec git add -f {} +
           git diff --cached --quiet || git commit -m "Add missing Playwright visual regression baselines"
           git push