test(e2e): make hub-client e2e suite pass on CI

Once the workflow could actually run the tests (see prior commit),
several real bugs and config gaps surfaced that had been hidden while
the workflow sat in the queue. None of these would have shown up
locally because the e2e suite had never been wired into anyone's
regular workflow.

- TS2345 in client.test.ts: installMockRepo used
  `ReturnType<typeof createMockHandle>` without supplying T, so the
  parameter defaulted to unknown. Forwarding T through makes the
  helper generic and the test compiles again.
- Node-side IndexedDB shim: projectFactory.ts runs in the Playwright
  test process (Node, not browser) but createSyncClient instantiates
  an IndexedDBStorageAdapter unconditionally. Without a shim every
  e2e test that called createProjectOnServer threw "indexedDB is not
  defined" before doing anything else. Import fake-indexeddb/auto,
  matching how sync-test-harness already handles vitest.
- Vite proxy target: hub-client's vite.config.ts proxies /auth/* and
  the websocket to VITE_HUB_SERVER (default http://localhost:3000),
  but globalSetup starts the e2e hub on port 3030 — so vite returned
  HTTP 500 from /auth/me on every test, blocking the in-browser
  hub-client from rendering the preview iframe. Pass
  VITE_HUB_SERVER=http://localhost:3030 to the webServer env.
- Functional config picks up visual specs: testDir './e2e' with no
  testIgnore was finding setup-screens.visual.spec.ts and running it
  through the functional config, which has no missing-baseline retry.
  Skip *.visual.spec.ts so those run only via playwright.visual.config.ts.
- CI workers: drop from 4 to 2. The 4-workers value was sized for the
  original ubuntu-latest-8x; under ubuntu-latest (2 cores) random
  tests stalled in the WASM render pipeline and missed the 45s
  preview-iframe deadline non-deterministically. Reproduced locally
  with 4 workers (a different test failed each run); 2 workers
  cleared all flakes.
- Hub-client WASM gap (bd-izfv): the project-render path
  (RenderToHtmlRenderer) drops the user_grammars provider on the
  floor, so the smoke-all fixture
  highlighting/03-user-grammar/03-user-grammar-toml.qmd renders a
  bare <code> block instead of highlighted TOML. Add a
  SKIP_WASM_UNSUPPORTED map in smokeAllDiscovery.ts pointing at
  bd-izfv (which has a complete TDD plan on branch
  beads/bd-izfv-thread-user-grammars).

Author: gordonwoodhull

hub-client/e2e/helpers/projectFactory.ts

@@ -5,6 +5,10 @@
  * - `seedProjectInBrowser()` runs in the browser via page.evaluate()
  */
 
+// createSyncClient instantiates IndexedDBStorageAdapter unconditionally;
+// shim indexedDB in Node so the helper can run outside the browser.
+import 'fake-indexeddb/auto';
+
 import { readFileSync } from 'node:fs';
 import {
   createSyncClient,

hub-client/e2e/helpers/smokeAllDiscovery.ts

@@ -20,6 +20,16 @@ const SKIP_PRINTS_MESSAGE: Set<string> = new Set([
   'quarto-test/expected-error.qmd',
 ]);
 
+// Tests that fail in the hub-client preview because of a known gap in
+// the WASM render pipeline. The native CLI runner handles these. Skip
+// in the browser until the gap is closed.
+const SKIP_WASM_UNSUPPORTED: Map<string, string> = new Map([
+  [
+    'highlighting/03-user-grammar/03-user-grammar-toml.qmd',
+    'bd-izfv: RenderToHtmlRenderer drops user_grammars on the project-render path',
+  ],
+]);
+
 // ---------------------------------------------------------------------------
 // Types
 // ---------------------------------------------------------------------------
@@ -231,7 +241,15 @@ function parseFormatSpec(
 // Skip logic
 // ---------------------------------------------------------------------------
 
-export function shouldSkip(runConfig: RunConfig | null): string | null {
+export function shouldSkip(
+  runConfig: RunConfig | null,
+  relPath?: string,
+): string | null {
+  if (relPath) {
+    const wasmReason = SKIP_WASM_UNSUPPORTED.get(relPath);
+    if (wasmReason) return `WASM unsupported: ${wasmReason}`;
+  }
+
   if (!runConfig) return null;
 
   if (runConfig.skip) {

hub-client/e2e/smoke-all.spec.ts

@@ -39,7 +39,7 @@ test.describe('smoke-all E2E tests', () => {
   test.setTimeout(60000);
 
   for (const fixture of allTests) {
-    const skipReason = shouldSkip(fixture.runConfig);
+    const skipReason = shouldSkip(fixture.runConfig, fixture.relPath);
 
     for (const spec of fixture.formatSpecs) {
       const testName = `${fixture.relPath} [${spec.format}]`;

hub-client/playwright.config.ts

@@ -11,14 +11,21 @@ import { defineConfig, devices } from '@playwright/test';
  */
 export default defineConfig({
   testDir: './e2e',
+  // Visual-regression specs run via playwright.visual.config.ts (which has
+  // the --update-snapshots-on-missing retry flow); exclude them from the
+  // functional run so a missing baseline isn't a hard failure here.
+  testIgnore: '**/*.visual.spec.ts',
   // Parallel tests are OK - they use different documents, single sync server handles concurrency
   fullyParallel: true,
   // Fail on `test.only` in CI
   forbidOnly: !!process.env.CI,
   // Retries for flaky tests in CI
   retries: process.env.CI ? 2 : 0,
-  // Parallel workers
-  workers: process.env.CI ? 4 : undefined,
+  // Parallel workers. Match the runner's CPU count: ubuntu-latest has
+  // 2 cores. Running more workers than cores causes the WASM render
+  // pipeline to stall under contention and individual tests miss the
+  // preview-render deadline non-deterministically.
+  workers: process.env.CI ? 2 : undefined,
   // HTML reporter
   reporter: 'html',
 
@@ -61,5 +68,11 @@ export default defineConfig({
     reuseExistingServer: !process.env.CI,
     // Timeout for server to start
     timeout: 120000,
+    // Vite proxies /auth/* and the websocket to VITE_HUB_SERVER
+    // (default http://localhost:3000). globalSetup starts the e2e hub
+    // on port 3030, so point Vite at that port.
+    env: {
+      VITE_HUB_SERVER: 'http://localhost:3030',
+    },
   },
 });

ts-packages/quarto-sync-client/src/client.test.ts

@@ -105,9 +105,9 @@ function noopCallbacks(): SyncClientCallbacks {
  * - `create()` returns `createHandle`
  * - networkSubsystem never emits 'peer', so `waitForPeer` always times out
  */
-function installMockRepo(
-  connectHandle: ReturnType<typeof createMockHandle>['handle'],
-  createHandle: ReturnType<typeof createMockHandle>['handle'],
+function installMockRepo<T>(
+  connectHandle: ReturnType<typeof createMockHandle<T>>['handle'],
+  createHandle: ReturnType<typeof createMockHandle<T>>['handle'],
 ) {
   const mockNetworkSubsystem = {
     on: vi.fn(),