Clean up attribution: remove debug logging, unused parameter, and spike test

Remove console.log/warn/error statements used during development,
drop unused _identities parameter from useAttribution() (identities
flow through AttributionContext), and delete the stale spike test
that documented the old Automerge Text API patch format.

Author: shikokuchuo

hub-client/src/components/Editor.tsx

@@ -373,7 +373,7 @@ export default function Editor({ project, files, fileContents, onDisconnect, onC
       return false;
     } catch { return false; }
   }, [currentFormat, astJson]);
-  const attribution = useAttribution(attributionEnabled ? (currentFile?.path ?? null) : null, identities ?? {}, displayContent);
+  const attribution = useAttribution(attributionEnabled ? (currentFile?.path ?? null) : null, displayContent);
   const attributionContextValue = attribution ? {
     attributionMap: attribution.attributionMap,
     byteToCharMap: attribution.byteToCharMap,

hub-client/src/components/render/ReactAstDebugRenderer.tsx

@@ -544,11 +544,7 @@ const AstRenderer = ({ ast, onNavigateToDocument, setAst }: {
     const astContext = ast.astContext;
 
     const nodeAttributionValue = useMemo(() => {
-        if (!astContext || !attributionCtx) {
-            if (!astContext) console.warn('[ast-debug] No astContext in AST JSON');
-            if (!attributionCtx) console.warn('[ast-debug] No attribution context (hook returned null)');
-            return null;
-        }
+        if (!astContext || !attributionCtx) return null;
 
         try {
             // Populate files[0].content from the Automerge source text
@@ -577,8 +573,7 @@ const AstRenderer = ({ ast, onNavigateToDocument, setAst }: {
                         attributionCtx.identities,
                     ),
             };
-        } catch (err) {
-            console.error('[ast-debug] Failed to build NodeAttribution:', err);
+        } catch {
             return null;
         }
     }, [astContext, attributionCtx]);

hub-client/src/hooks/useAttribution.test.ts

@@ -39,11 +39,6 @@ const mockUpdateAttributionMap = vi.mocked(updateAttributionMap);
 const mockBuildByteToCharMap = vi.mocked(buildByteToCharMap);
 const mockGetFileHandle = vi.mocked(getFileHandle);
 
-const TEST_IDENTITIES = {
-  actor1: { name: 'Alice', color: '#E91E63' },
-  actor2: { name: 'Bob', color: '#2196F3' },
-};
-
 function createMockMap(overrides?: Partial<AttributionMap>): AttributionMap {
   return {
     entries: [{ actor: 'actor1', time: 1000 }],
@@ -68,7 +63,7 @@ describe('useAttribution', () => {
     mockGetFileHandle.mockReturnValue(null);
 
     const { result } = renderHook(() =>
-      useAttribution('index.qmd', TEST_IDENTITIES, 'hello')
+      useAttribution('index.qmd', 'hello')
     );
 
     expect(result.current).toBeNull();
@@ -86,7 +81,7 @@ describe('useAttribution', () => {
     );
 
     const { result } = renderHook(() =>
-      useAttribution('index.qmd', TEST_IDENTITIES, 'hello')
+      useAttribution('index.qmd', 'hello')
     );
 
     // Initially null while building
@@ -112,7 +107,7 @@ describe('useAttribution', () => {
     mockUpdateAttributionMap.mockReturnValue(updatedMap);
 
     const { result, rerender } = renderHook(
-      ({ text }) => useAttribution('index.qmd', TEST_IDENTITIES, text),
+      ({ text }) => useAttribution('index.qmd', text),
       { initialProps: { text: 'hello' } },
     );
 
@@ -146,7 +141,7 @@ describe('useAttribution', () => {
     });
 
     const { result, rerender } = renderHook(
-      ({ text }) => useAttribution('index.qmd', TEST_IDENTITIES, text),
+      ({ text }) => useAttribution('index.qmd', text),
       { initialProps: { text: 'hello' } },
     );
 
@@ -183,7 +178,7 @@ describe('useAttribution', () => {
       .mockResolvedValueOnce(createMockMap({ processedHistoryIndex: 2 }));
 
     const { result, rerender } = renderHook(
-      ({ path }) => useAttribution(path, TEST_IDENTITIES, 'hello'),
+      ({ path }) => useAttribution(path, 'hello'),
       { initialProps: { path: 'file1.qmd' } },
     );
 
@@ -217,7 +212,7 @@ describe('useAttribution', () => {
     mockBuildAttributionMap.mockReturnValue(new Promise(() => {})); // never resolves
 
     const { unmount } = renderHook(() =>
-      useAttribution('index.qmd', TEST_IDENTITIES, 'hello')
+      useAttribution('index.qmd', 'hello')
     );
 
     expect(mockBuildAttributionMap).toHaveBeenCalledTimes(1);

hub-client/src/hooks/useAttribution.ts

@@ -49,7 +49,6 @@ const DEBOUNCE_MS = 500;
 
 export function useAttribution(
   filePath: string | null,
-  _identities: Record<string, ActorIdentity>,
   sourceText: string,
 ): UseAttributionResult | null {
   const [result, setResult] = useState<UseAttributionResult | null>(null);
@@ -79,28 +78,24 @@ export function useAttribution(
 
     const handle = getFileHandle(path);
     if (!handle) {
-      console.warn('[attribution] No file handle for', path);
       setResult(null);
       mapRef.current = null;
       return;
     }
 
-    console.log('[attribution] Starting build for', path);
     buildAttributionMap(handle, 'text', controller.signal).then(map => {
       if (controller.signal.aborted) return;
 
       if (map) {
-        console.log('[attribution] Build complete:', map.entries.length, 'chars,', map.processedHistoryIndex, 'history entries');
         const byteToChar = buildByteToCharMap(sourceTextRef.current);
         mapRef.current = map;
         setResult({ attributionMap: map, byteToCharMap: byteToChar });
       } else {
-        console.warn('[attribution] Build returned null');
         mapRef.current = null;
         setResult(null);
       }
-    }).catch(err => {
-      console.error('[attribution] Build failed:', err);
+    }).catch(() => {
+      // Build failed — leave result as-is
     });
   }, []);
 

hub-client/src/services/attribution-spike.test.ts

@@ -144,8 +144,6 @@ export async function buildAttributionMap(
   const viewable = handle as unknown as ViewableHandle;
   const history = viewable.history();
 
-  console.log('[attribution:build] history:', history ? history.length + ' entries' : 'undefined');
-
   if (!history) return null;
 
   if (history.length === 0) {
@@ -180,7 +178,6 @@ export async function buildAttributionMap(
       const decodedCurr = decodeHeads(currHeads as Parameters<typeof decodeHeads>[0]);
       let patches: unknown[];
 
-      try {
       if (prevHeads === null) {
         patches = diff(
           viewable.doc() as Parameters<typeof diff>[0],
@@ -195,14 +192,6 @@ export async function buildAttributionMap(
           decodedCurr as unknown as Heads,
         );
       }
-      } catch (err) {
-        console.error('[attribution:build] diff() failed at history entry', i, err);
-        throw err;
-      }
-
-      if (i < 3 && patches.length > 0) {
-        console.log('[attribution:build] Entry', i, 'patches:', JSON.stringify(patches.slice(0, 3)));
-      }
 
       for (const patch of patches) {
         if (isTextPatch(patch, textFieldName)) {