Skip to content

Commit ffca3ea

Browse files
cscheidclaude
andcommitted
Retarget attribution integration test imports to @quarto/preview-renderer
Two PR-#190 integration tests imported the framework + previewRegistry via relative paths that were valid before the ts-packages reorg: - q2-debug/attribution.integration.test.tsx — `Ast` from `'../framework'` - q2-preview/attribution.integration.test.tsx — same, plus `previewRegistry` from `'./registry'` Both paths point at locations the feature branch moved into ts-packages/preview-renderer. The standalone `tsc --noEmit` runs and `cargo xtask verify --skip-hub-tests` missed it because `vitest.integration.config.ts` only picks these files up via `test:integration` / `test:ci`. CI surfaced it on PR #214 (q2-debug + q2-preview attribution test files: 2 failed, 6 passed). Retarget both: - `Ast` → `@quarto/preview-renderer/framework` - `previewRegistry` → `@quarto/preview-renderer/q2-preview` `q2DebugRegistry` stays on its relative `./registry` import — q2-debug itself didn't move with the framework extraction. Full `cargo xtask verify` (including `test:integration` + `test:ci`) now green locally; the hub-client suite reports 66 integration tests and 79 CI tests passing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 2a18272 commit ffca3ea

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

hub-client/src/components/render/q2-debug/attribution.integration.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*/
44
import { describe, it, expect, afterEach } from 'vitest';
55
import { render, cleanup, fireEvent } from '@testing-library/react';
6-
import { Ast } from '../framework';
6+
import { Ast } from '@quarto/preview-renderer/framework';
77
import { q2DebugRegistry } from './registry';
88

99
afterEach(() => {

hub-client/src/components/render/q2-preview/attribution.integration.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
*/
44
import { describe, it, expect, afterEach } from 'vitest';
55
import { render, cleanup, fireEvent } from '@testing-library/react';
6-
import { Ast } from '../framework';
7-
import { previewRegistry } from './registry';
6+
import { Ast } from '@quarto/preview-renderer/framework';
7+
import { previewRegistry } from '@quarto/preview-renderer/q2-preview';
88

99
afterEach(() => {
1010
cleanup();

0 commit comments

Comments
 (0)