fix(release): pinned-toolchain targets + Windows npm spawn (bd-c6l13j79, dry-run iteration 1)#279
Merged
Merged
Conversation
v0.1.0 dry-run iteration 1 (run 27448388974) failures: - linux_amd64/linux_arm64/darwin_amd64: E0463 'can't find crate for core' — the dtolnay toolchain action adds the matrix target to the latest nightly, but cargo resolves the dated nightly pinned in rust-toolchain.toml (bd-at72), which auto-installs with only its declared targets. Add an explicit 'rustup target add' step against the pinned toolchain. - windows_amd64: spawnSync npm ENOENT in stage-keyring's npmPackFetcher (npm is npm.cmd on Windows; execFileSync needs shell:true, and Node >=20.12 rejects .cmd without it). Arguments are fixed package specifiers, so shell quoting is not a concern. Keyring staging tests still 10/10; real darwin-x64 fetch re-verified locally; actionlint clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the v0.1.0 release dry-run (run 27448388974):
E0463: can't find crate for core— the dtolnay toolchain action adds the matrix target to the latest nightly, but cargo resolves the dated nightly pinned inrust-toolchain.toml(bd-at72), which auto-installs with only its own declared targets (that's also whyweb-payloadspassed: wasm32 is in the pin). Fix: explicitrustup target add ${{ matrix.target }}step against the pinned toolchain.spawnSync npm ENOENTwhilestage-keyring.mjsfetched the non-hostkeyring-win32-arm64-msvcaddon — npm isnpm.cmdon Windows andexecFileSyncneedsshell: true(Node ≥20.12 rejects.cmdwithout it). Arguments are fixed package specifiers, so no shell-quoting exposure.Meanwhile darwin_arm64 passed end-to-end, validating everything downstream: per-target MCP bundle with both darwin keyring addons, bundled-defaults injection (verify gate saw
default …: bundled×3, no placeholders), tar.gz + sha256, minisign signing self-verified against the install.sh pinned key.Keyring staging tests 10/10; real darwin-x64
npm packfetch re-verified locally; actionlint clean. After merge: delete and re-push tagv0.1.0for iteration 2 (remaining known risk: the musl legs haven't compiled aws-lc-sys/vendored-openssl yet).🤖 Generated with Claude Code