fix(hub-mcp): spawn test server without inheriting developer auth env#301
Merged
Merged
Conversation
McpTestClient.start() inherited the full shell env, so a developer with QUARTO_HUB_MCP_CLIENT_ID/SECRET set made the spawned server take the OS-keychain path and fail nondeterministically against a populated keychain. Strip those two vars from the default child env; tests passing an explicit env are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bd-uyiqciqk.
McpTestClient.start()spawned the MCP server inheriting the full shell env.A developer with
QUARTO_HUB_MCP_CLIENT_ID/SECRETset (real auth config) made the spawned test server take the OS-keychain credential path. That fails nondeterministically against a populated keychain ("item already exists in the keychain") — breaking therequire-online/hub-mcp/exit-drainsuites locally, while CI's clean env stayed green.The fix strips those two auth-gating vars from the default child env, so the spawned server runs unauthenticated. Tests that exercise auth (e.g.
e2e-auth) pass their own explicit env and are unaffected.