chore(deps): remove unused dependency declarations#306
Closed
shikokuchuo wants to merge 1 commit into
Closed
Conversation
Member
|
I think I'm missing something here, because a lot of the lines being removed reference crates we do need ( |
Member
Author
|
I had Claude just double-check on Ariadne as you mentioned it.
I was just trying to see how much we could clean up 'for free' - and it seems not much: the only 2 crates removed are |
Found via cargo-machete, verified by full cargo xtask verify (native + WASM). 59 redundant declarations removed across 27 crates; pretty_assertions + diff drop from Cargo.lock. Kept link/macro/build deps (openssl-sys vendored, quarto-error-message-macros proc-macro, tokio, sha2 build.rs).
5c0ce89 to
7f36c28
Compare
Member
|
Ok, got it. I'm fine with merging this, I just wanted to know the context (we also have a lockfile conflict somehow). |
Member
Author
|
I just wanted to share the result really as I'd attempted it... I've re-based so should be ok to merge. Also fine not to merge, and leave this all for later... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 59 unused dependency declarations across 27 crates — manifest hygiene, no source changes.
What we used
cargo-machete(--with-metadata) to find unused deps, then Claude verified every hit "by hand" before removing it.Intentionally risk-averse
We removed only declarations with zero usage and left anything that looks unused but isn't. Kept on purpose:
openssl-sys(quarto) — link-only, behind thevendored-opensslfeaturequarto-error-message-macros(quarto-parse-errors) — proc-macro; derive name ≠ crate nametokio(quarto-lsp-core) — macro-based usagesha2(quarto-sass) — used inbuild.rs(machete doesn't scan build scripts)cc+ the wasm/fuzz/patch-crate deps — left untouchedImpact
Only
pretty_assertions(+diff) drops from the build graph entirely; the rest were redundant declarations of crates still used elsewhere.How we tested
Full
cargo xtask verify— all 14 steps green, coveringcargo build --workspace,cargo nextest run --workspace, the WASM rebuild, and the hub-client build/tests. The all-targets build is itself the proof: any test relying on a removed dev-dep would have failed to compile.Strand: bd-e3lv7eg3.