chore(hub): migrate samod to quarto-dev/samod@access-policy (automerge 0.10)#355
Merged
Merged
Conversation
…ge 0.10) Switch the vendored samod fork from quarto-dev@q2 (samod 0.9.0 / automerge 0.8.0) to shikokuchuo@access-policy (samod 0.12.1 / automerge 0.10.0) in quarto-hub and quarto-preview. AccessPolicy is now synchronous (should_allow → is_allowed, borrowed args, bool return); AuditAccessPolicy ported mechanically and its "Document accessed" audit log now has a tracing-capture regression test. No automerge 0.8→0.10 source breaks surfaced; single unified automerge 0.10 in the lockfile. bd-qp353u2b.
samod 0.12 consults the access policy on every inbound sync message, so a document open logged 'Document accessed' 2-3 times. Restore once-per- (peer, doc) semantics via a dedup set in AuditAccessPolicy, pruned per peer on disconnect (forget_peer).
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Same branch, identical commit c5a06c39; canonical long-term home moved from the shikokuchuo fork to quarto-dev.
shikokuchuo
changed the title
Member
|
Thanks! |
gordonwoodhull
added a commit
that referenced
this pull request
Jul 8, 2026
The smoke-all suite ran serially (workers: 1) on the theory that the 75s-timeout flakiness came from the WASM render pipeline stalling under CPU contention on a '2-core' runner. That diagnosis was wrong on both counts: the public-repo ubuntu-latest runner has 4 vCPUs, and the real cause was server-side sync contention — fixed by the samod-0.12 hub upgrade (PR #355) on 2026-07-03. Since #355 the nightly has been clean at workers: 1 for several consecutive nights. Dispatch stress runs on this branch then confirmed 78/78 with zero flaky at both 3 and 4 workers (~3.4m, vs the serial ~4.8m), proving the fix holds under concurrent load: - run 28840734138 — 4 workers, nproc=4, 78 passed, 0 flaky (3.4m) - run 28871855320 — 3 workers, nproc=4, 78 passed, 0 flaky (3.4m) Restore parallelism at 3 (reserves one core for the co-resident hub + vite-preview + node). SMOKE_ALL_WORKERS + the smoke-all-workers dispatch input remain as a knob to re-stress at 4 if flakiness ever returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quarto-dev/samod@q2(samod 0.9 / automerge 0.8) toquarto-dev/samod@access-policy(samod 0.12.1 / automerge 0.10) inquarto-hubandquarto-preview.AuditAccessPolicyto the new synchronousAccessPolicytrait (is_allowed).(peer, doc)connection), so a document open logged "Document accessed" 2–3 times. Restored once-per-(peer, doc)semantics with a dedup set inAuditAccessPolicy, pruned per-peer on disconnect (forget_peer).Tracked as braid
bd-qp353u2b.