fix(hub-client): unbreak main — escape lone tilde in changelog (bd-q5o7ekzn)#381
Merged
Merged
Conversation
…r test The changelog entry added in 6cd4dd5 wrote "(now ~37MB)". The lone `~` is parsed by qmd as an opening subscript with no close, producing [Q-2-17] Unclosed Subscript. changelogRender.wasm.test.ts renders changelog.md through the WASM parser and asserts success, so this failed the TS Test Suite on both ubuntu and macOS. Reword to "(now about 37 MB)" — avoids the subscript delimiter entirely (clearer for the rendered About tab than a backslash escape). Verified via full `cargo xtask verify` (fresh WASM rebuild): all 129 hub-client WASM tests pass, including changelog.md renders successfully. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…kzn) Root-cause writeup for the two sequential TS Test Suite failures on main (PWA precache ceiling, then a self-inflicted changelog unclosed-subscript) and the push-without-local-verify process gap that let both reach main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
main's TS Test Suite is red. The changelog entry added in6cd4dd5awrote
(now ~37MB). The lone~is parsed by qmd as an opening subscriptwith no close →
[Q-2-17] Unclosed Subscript.changelogRender.wasm.test.tsrenders
hub-client/changelog.mdthrough the WASM parser and assertssuccess, so it fails on both ubuntu and macOS.
This PR reworts the tilde (
~37MB→about 37 MB) — avoids the subscriptdelimiter entirely, which reads better in the rendered About tab than a
\~escape.Context (two-failure sequence)
maximumFileSizeToCacheInByteslimit, andvite-plugin-pwathrows theoversize warning as fatal. Fixed on
mainin6cfc098f(ceiling → 64MB);the "Build WASM module" step is green again.
the build started passing (and was self-inflicted by the changelog entry
accompanying fix Fix yaml-tags non-deterministic write #1).
Verification
cd hub-client && npm run test:wasm→changelog.md renders successfullyFAILED with[Q-2-17] Unclosed Subscript.cargo xtask verify→ exit 0, "All verificationsteps passed!"; 129/129 hub-client WASM tests pass.
Notes
claude-notes/plans/2026-07-07-broken-main-ci-changelog-subscript.md)recording the root-cause analysis and a process follow-up: both
breakages were locally catchable via
cargo xtask verify, which wasskipped before pushing. Strand:
bd-q5o7ekzn.already on
main.🤖 Generated with Claude Code