Address review findings batch 3 for posit-connect-cloud provider

Three hardening fixes:
- Trim POSIT_CONNECT_CLOUD_ACCOUNT_ID env var to prevent CI/CD
  copy-paste whitespace from causing silent match failure (.17)
- Enforce minimum 5-second device code poll interval per RFC 8628 §3.5
  to prevent tight loop if server returns interval=0 (.18)
- Catch transient errors (HTTP 500, network timeouts) during 30-minute
  revision polling with consecutive error threshold before aborting,
  since ~1,800 poll calls makes transient failures likely (.19)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: cderv

src/publish/posit-connect-cloud/api/index.ts

@@ -375,7 +375,7 @@ export async function pollForToken(
   initialInterval: number,
   expiresIn: number,
 ): Promise<TokenResponse> {
-  let interval = initialInterval;
+  let interval = Math.max(initialInterval, 5);
   const params = new URLSearchParams({
     scope: kOAuthScope,
     client_id: env.clientId,

src/publish/posit-connect-cloud/posit-connect-cloud.ts

@@ -41,7 +41,7 @@ import {
   writeStoredToken,
   writeStoredTokens,
 } from "./api/index.ts";
-import { Account, PositConnectCloudToken } from "./api/types.ts";
+import { Account, PositConnectCloudToken, Revision } from "./api/types.ts";
 
 export const kPositConnectCloud = "posit-connect-cloud";
 const kPositConnectCloudDescription = "Posit Connect Cloud";
@@ -356,7 +356,7 @@ async function publish(
         "No publishable accounts found for the provided access token.",
       );
     }
-    const envAccountId = Deno.env.get(kPositConnectCloudAccountIdVar);
+    const envAccountId = Deno.env.get(kPositConnectCloudAccountIdVar)?.trim();
     if (envAccountId) {
       const match = publishable.find((a) => a.id === envAccountId);
       if (!match) {
@@ -501,6 +501,8 @@ async function publish(
       // Poll revision status
       const pollStartTime = Date.now();
       let lastStatus = "";
+      let consecutiveErrors = 0;
+      const kMaxConsecutiveErrors = 5;
       while (true) {
         if (Date.now() - pollStartTime > kRevisionPollTimeoutMs) {
           throw new Error(
@@ -509,7 +511,27 @@ async function publish(
           );
         }
 
-        const revision = await client.getRevision(revisionId);
+        let revision: Revision;
+        try {
+          revision = await client.getRevision(revisionId);
+          consecutiveErrors = 0;
+        } catch (err) {
+          if (err instanceof ApiError || err instanceof TypeError) {
+            consecutiveErrors++;
+            publishDebug(
+              `Revision poll error (${consecutiveErrors}/${kMaxConsecutiveErrors}): ${err}`,
+            );
+            if (consecutiveErrors >= kMaxConsecutiveErrors) {
+              throw new Error(
+                "Lost connection to Connect Cloud while monitoring deployment. " +
+                  "The deployment may still succeed — check the dashboard for status.",
+              );
+            }
+            await sleep(2000);
+            continue;
+          }
+          throw err;
+        }
 
         // Log status changes
         if (revision.status && revision.status !== lastStatus) {