Skip to content

Commit 2254b54

Browse files
cdervclaude
andcommitted
Fix chromium branch in quarto check to await async methods
The chromium fallback branch in chromeCb() accessed binDir and installedVersion as properties but they are async functions on the InstallableTool interface. This was pre-existing dead code (the name comparison never matched), but now reachable after the registry key lookup fix. Properly await both methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 6808369 commit 2254b54

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

src/command/check/check.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -474,16 +474,20 @@ async function checkInstall(conf: CheckConfiguration) {
474474
chromeHeadlessOutput.push(
475475
`${kIndent}Using: Chromium installed by Quarto`,
476476
);
477-
if (chromiumQuarto?.binDir) {
478-
chromeHeadlessOutput.push(
479-
`${kIndent}Path: ${chromiumQuarto?.binDir}`,
480-
);
481-
chromeJson["path"] = chromiumQuarto?.binDir;
477+
if (chromiumQuarto.binDir) {
478+
const binPath = await chromiumQuarto.binDir();
479+
if (binPath) {
480+
chromeHeadlessOutput.push(
481+
`${kIndent}Path: ${binPath}`,
482+
);
483+
chromeJson["path"] = binPath;
484+
}
482485
}
486+
const chromiumVersion = await chromiumQuarto.installedVersion();
483487
chromeHeadlessOutput.push(
484-
`${kIndent}Version: ${chromiumQuarto.installedVersion}`,
488+
`${kIndent}Version: ${chromiumVersion}`,
485489
);
486-
chromeJson["version"] = chromiumQuarto.installedVersion;
490+
chromeJson["version"] = chromiumVersion;
487491
} else {
488492
chromeHeadlessOutput.push(`${kIndent}Chrome: (not detected)`);
489493
chromeJson["installed"] = false;

0 commit comments

Comments
 (0)