Revert siteUrl pass-through for Connect Cloud rendering (.11)

During production testing, we discovered that Connect Cloud serves
content at a different domain than the dashboard URL stored in
_publish.yml:

- Dashboard URL: connect.posit.cloud/account/content/<id>
- Serving URL: <id>.share.connect.posit.cloud/

Passing the dashboard URL as siteUrl would override the correct
window.location.host fallback in linkExternalFilter, causing all
links to be misclassified as external. The same mismatch would
affect canonical URLs and Open Graph metadata.

This differs from gh-pages where the published URL and serving URL
are the same domain, making siteUrl pass-through correct there.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: cderv

src/publish/posit-connect-cloud/posit-connect-cloud.ts

@@ -462,12 +462,16 @@ async function publish(
   info("");
 
   // Step 2: Render and stage
+  // Note: siteUrl is intentionally not passed here. Connect Cloud serves
+  // content at a different domain (*.share.connect.posit.cloud) than the
+  // dashboard URL stored in _publish.yml (connect.posit.cloud/account/content/id).
+  // Passing the dashboard URL would break linkExternalFilter by overriding
+  // the correct window.location.host fallback in the rendered HTML.
   const publishFiles = await renderForPublish(
     render,
     kPositConnectCloud,
     type,
     title,
-    type === "site" ? target?.url : undefined,
   );
 
   // Step 3: Bundle and upload

tests/docs/manual/publish-connect-cloud/README.md

@@ -142,8 +142,6 @@ This content was updated for Test 4.
 - [ ] URL is same as Test 3
 - [ ] Hard-refresh (Ctrl+F5) shows updated text
 - [ ] About page still works
-- [ ] External link to quarto.org opens in new tab (siteUrl active → linkExternalFilter works)
-- [ ] View source: external link has appropriate attributes (not treated as internal link)
 - [ ] No duplicate content created on dashboard
 
 **Cleanup:** Revert the edit: