Guard log file read with Test-Path in signing action

cderv · cderv · commit 31fedec4fa1a · 2026-03-13T18:51:41.000+01:00
If msiexec fails before creating the log file, the unguarded
Get-Content call throws a secondary error that obscures the
real failure message.
diff --git a/.github/workflows/actions/sign-files/action.yml b/.github/workflows/actions/sign-files/action.yml
@@ -71,7 +71,7 @@ runs:
           $process = Start-Process msiexec -ArgumentList '/i', 'smtools-windows-x64.msi', '/quiet', '/qn', '/log', 'smtools-windows-x64.log' -Wait -PassThru
           if ($process.ExitCode -ne 0) {
             Write-Output "::error title=Install Error::msiexec failed with exit code $($process.ExitCode)"
-            Get-Content smtools-windows-x64.log -Tail 50
+            if (Test-Path smtools-windows-x64.log) { Get-Content smtools-windows-x64.log -Tail 50 }
             exit 1
           }
           # Verify smctl is actually on disk before declaring success

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ runs:`
`71`	`71`	`$process = Start-Process msiexec -ArgumentList '/i', 'smtools-windows-x64.msi', '/quiet', '/qn', '/log', 'smtools-windows-x64.log' -Wait -PassThru`
`72`	`72`	`if ($process.ExitCode -ne 0) {`
`73`	`73`	`Write-Output "::error title=Install Error::msiexec failed with exit code $($process.ExitCode)"`
`74`		`- Get-Content smtools-windows-x64.log -Tail 50`
	`74`	`+ if (Test-Path smtools-windows-x64.log) { Get-Content smtools-windows-x64.log -Tail 50 }`
`75`	`75`	`exit 1`
`76`	`76`	`}`
`77`	`77`	`# Verify smctl is actually on disk before declaring success`