Skip to content

Commit 5e21233

Browse files
committed
Address review feedback on test matrix and skill docs
- Fix inconsistent verification rules in README (conditional by test type) - Add excluded-file test case (T10b) for files not in project inputs - Add PowerShell equivalents for background preview examples in skill
1 parent 75b1f91 commit 5e21233

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

.claude/commands/quarto-preview-test/SKILL.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,16 @@ Filter log entries with `grep` or `jq` for structured output.
4343
### In background
4444

4545
```bash
46+
# Linux/macOS
4647
./package/dist/bin/quarto preview <file> --no-browser --port 4444 &
4748
PREVIEW_PID=$!
4849
# ... run verification ...
4950
kill $PREVIEW_PID
51+
52+
# Windows (PowerShell)
53+
$proc = Start-Process -PassThru -NoNewWindow ./package/dist/bin/quarto.cmd preview, <file>, --no-browser, --port, 4444
54+
# ... run verification ...
55+
Stop-Process $proc
5056
```
5157

5258
## Edit-Verify Cycle

tests/docs/manual/preview/README.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@ For browser interaction, `/agent-browser` is preferred over Chrome DevTools MCP
1010

1111
## Test Matrix: quarto_ipynb Accumulation (#14281)
1212

13-
After every test, verify:
14-
1. `ls *.quarto_ipynb*` — only one `{name}.quarto_ipynb` should exist (no `_1`, `_2` variants)
15-
2. After Ctrl+C exit — no `.quarto_ipynb` files remain
13+
After every test involving Jupyter execution (Python/Julia cells), verify:
14+
1. `ls *.quarto_ipynb*` — at most one `{name}.quarto_ipynb` (no `_1`, `_2` variants)
15+
2. After Ctrl+C exit — no `.quarto_ipynb` files remain (unless `keep-ipynb: true`)
16+
17+
For tests without Jupyter execution (T9, T10, T11), verify no `.quarto_ipynb` files are created at all.
1618

1719
### P1: Critical
1820

@@ -85,6 +87,13 @@ After every test, verify:
8587
- **Steps:** Preview, save 3 times, check for `.quarto_ipynb` files
8688
- **Expected:** No `.quarto_ipynb` files. Knitr doesn't use Jupyter intermediate.
8789

90+
#### T10b: File excluded from project inputs (regression)
91+
92+
- **Setup:** Website project with `_quarto.yml`. Create `excluded.qmd` with a Python cell that is NOT listed in the project's input files (e.g., starts with `_`)
93+
- **Steps:** `quarto preview _excluded.qmd`, save 3 times, check files, Ctrl+C
94+
- **Expected:** Falls back to single-file preview (not project preview). At most one `.quarto_ipynb`.
95+
- **Catches:** Context reuse from cmd.ts incorrectly applying project semantics to excluded files
96+
8897
### P3: Nice-to-Have
8998

9099
#### T11: Native .ipynb file

0 commit comments

Comments
 (0)