[FIXME] Just want to try if this works

Author: tarleb

src/resources/filters/ast/customnodes.lua

@@ -243,6 +243,11 @@ function create_custom_node_scaffold(t, context)
   return result
 end
 
+
+local ptype  = pandoc.utils.type
+local InlinesMT = getmetatable(pandoc.Inlines{})
+local BlocksMT = getmetatable(pandoc.Blocks{})
+
 function create_emulated_node(t, tbl, context, forwarder)
   local result = create_custom_node_scaffold(t, context)
   tbl.t = t -- set t always to custom ast type
@@ -340,26 +345,27 @@ _quarto.ast = {
         end
         local node = node_accessor(table)
         local t = pandoc.utils.type(value)
-        -- FIXME this is broken; that can only be "Block", "Inline", etc
-        if t == "Div" or t == "Span" then
-          local custom_data, t, kind = _quarto.ast.resolve_custom_data(value)
-          if custom_data ~= nil then
-            value = custom_data
-          end
-        end
+        quarto_assert(t ~= 'Div' and t ~= 'Span', "")
         if index > #node.content then
           _quarto.ast.grow_scaffold(node, index)
         end
-        local pt = pandoc.utils.type(node.content[index])
-        if pt == "Block" then
-          node.content[index].content =
-            _quarto.modules.attribcheck.ensure_blocks(value)
-        elseif pt == "Inline" then
-          node.content[index].content =
-            _quarto.modules.attribcheck.ensure_inlines(value)
+        local inner_node = node.content[index]
+        quarto_assert(inner_node ~= nil)
+        if t == "Block" then
+          inner_node.content = quarto.utils.as_blocks(value)
+        elseif t == "Inline" then
+          inner_node.content = quarto.utils.as_inlines(value)
         else
-          warn('Cannot handle type ' .. pt)
-          node.content[index].content = value
+          local innertype = pandoc.utils.type(inner_node)
+          if innertype == 'Block' then
+            inner_node.content = quarto.utils.as_blocks(value)
+          elseif innertype == 'Inline' then
+            inner_node.content = quarto.utils.as_inlines(value)
+          else
+            warn('Cannot find the right content type for value ' .. t)
+            warn(debug.traceback())
+            inner_node.content = value
+          end
         end
       end
     }

src/resources/filters/common/error.lua

@@ -15,8 +15,15 @@ function fail(message, level)
   end
 end
 
-function internal_error()
-  fail("This is an internal error. Please file a bug report at https://github.com/quarto-dev/quarto-cli/", 5)
+function internal_error(msg, level)
+  fail((msg and (msg .. '\n') or '') ..
+    "This is an internal error. Please file a bug report at https://github.com/quarto-dev/quarto-cli/", level or 5)
+end
+
+function quarto_assert (test, msg, level)
+  if not test then
+    internal_error(msg, level or 6)
+  end
 end
 
 function currentFile() 

src/resources/filters/common/log.lua

@@ -20,13 +20,14 @@ function warn(message, offset)
   io.stderr:write(lunacolors.yellow("WARNING (" .. caller_info(offset) .. ") " .. message .. "\n"))
 end
 
+local orig_error = error
 function error(message, offset)
   io.stderr:write(lunacolors.red("ERROR (" .. caller_info(offset) .. ") " .. message .. "\n"))
 end
 
 function fatal(message, offset)
   io.stderr:write(lunacolors.red("FATAL (" .. caller_info(offset) .. ") " ..message .. "\n"))
   -- TODO write stack trace into log, and then exit.
-  crash_with_stack_trace()  
+  orig_error('FATAL QUARTO ERROR', offset)
 end
--- luacov: enable
+-- luacov: enable

src/resources/filters/customnodes/callout.lua

@@ -260,11 +260,18 @@ function _callout_main()
         icon_color = "brand-color." .. callout_theme_color_map[callout.type]
       end
     end
+    local function is_nonempty_node (node)
+      return not not
+        (node or
+         (node.content and next(node.content)) or
+         next(node))
+    end
     if callout.attr.identifier == "" then
       return _quarto.format.typst.function_call("callout", { 
         { "body", _quarto.format.typst.as_typst_content(callout.content) },
         { "title", _quarto.format.typst.as_typst_content(
-          callout.title or pandoc.Plain(_quarto.modules.callouts.displayName(callout.type))
+          (not is_nonempty_node(callout.title) and callout.title) or
+          pandoc.Plain(_quarto.modules.callouts.displayName(callout.type))
         )},
         { "background_color", pandoc.RawInline("typst", background_color) },
         { "icon_color", pandoc.RawInline("typst", icon_color) },

src/resources/pandoc/datadir/_utils.lua

@@ -295,6 +295,34 @@ local function as_inlines(v)
   -- luacov: enable
 end
 
+--- FIXME cleanup, make PR
+ensure_blocks = function (obj)
+  local pt = ptype(obj)
+  if pt == 'Blocks' then
+    return obj
+  elseif pt == 'List' or pt == 'table' then
+    return setmetatable(obj, BlocksMT)
+  elseif pt == 'Inline' then
+      return setmetatable({pandoc.Plain{obj}}, BlocksMT)
+  elseif pt == 'Inlines' then
+    return setmetatable({pandoc.Plain(obj)}, BlocksMT)
+  else
+    return pandoc.Blocks(obj)
+  end
+end
+
+ensure_inlines = function (obj)
+  local pt = ptype(obj)
+  if pt == 'Inlines' then
+    return obj
+  elseif pt == 'List' or pt == 'table' then
+    return setmetatable(obj, InlinesMT)
+  else
+    return pandoc.Inlines(obj)
+  end
+end
+
+
 local function as_blocks(v)
   if v == nil then
     return pandoc.Blocks({})