Skip to content

Commit 9a9b89e

Browse files
committed
Fix CI: install rsvg-convert and verapdf when running all tests
The update-test-timing.yml and daily test-smokes.yml schedule runs pass `buckets: ""` (all tests), but rsvg-convert and verapdf were only installed when `buckets` contained specific bucket names. This caused 4 pdf-standard/ua-* tests to fail every run since Jan 26. Use the same `format('{0}', inputs.buckets) == ''` pattern already used elsewhere in this workflow to detect all-tests mode. Fixes weekly timing update failures and daily schedule failures.
1 parent 4127c26 commit 9a9b89e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/test-smokes.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ jobs:
141141
142142
- name: Install rsvg-convert for SVG conversion tests
143143
# Only do it on linux runner, and only if we are running the relevant tests
144-
if: runner.os == 'Linux' && (contains(inputs.buckets, 'render-pdf-svg-conversion') || contains(inputs.buckets, 'pdf-standard'))
144+
if: runner.os == 'Linux' && (format('{0}', inputs.buckets) == '' || contains(inputs.buckets, 'render-pdf-svg-conversion') || contains(inputs.buckets, 'pdf-standard'))
145145
run: |
146146
sudo apt-get update -y
147147
sudo apt-get install -y librsvg2-bin
@@ -202,7 +202,7 @@ jobs:
202202
quarto install tinytex
203203
204204
- name: Install veraPDF for PDF standard validation
205-
if: runner.os == 'Linux' && contains(inputs.buckets, 'pdf-standard')
205+
if: runner.os == 'Linux' && (format('{0}', inputs.buckets) == '' || contains(inputs.buckets, 'pdf-standard'))
206206
env:
207207
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
208208
run: |

0 commit comments

Comments
 (0)