Skip to content

Commit cc952d8

Browse files
committed
Make CI assert steps always run instead of skip-on-success
Assert steps now run unconditionally and check the condition inside, so they show as green (success) in the UI instead of grey (skipped).
1 parent 6df5d24 commit cc952d8

1 file changed

Lines changed: 15 additions & 7 deletions

File tree

.github/workflows/test-install.yml

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,13 @@ jobs:
8989
fi
9090
9191
- name: Assert install deprecation warning was shown
92-
if: steps.install-chromium.outputs.deprecation-warning != 'true'
9392
shell: bash
9493
run: |
95-
echo "::error::Deprecation warning missing from quarto install chromium output"
96-
exit 1
94+
if [ "${{ steps.install-chromium.outputs.deprecation-warning }}" != "true" ]; then
95+
echo "::error::Deprecation warning missing from quarto install chromium output"
96+
exit 1
97+
fi
98+
echo "Install deprecation warning found"
9799
98100
- name: Update chromium and capture result
99101
id: update-chromium
@@ -108,19 +110,25 @@ jobs:
108110
fi
109111
110112
- name: Assert update deprecation warning was shown
111-
if: steps.update-chromium.outputs.deprecation-warning != 'true'
112113
shell: bash
113114
run: |
114-
echo "::error::Deprecation warning missing from quarto update chromium output"
115-
exit 1
115+
if [ "${{ steps.update-chromium.outputs.deprecation-warning }}" != "true" ]; then
116+
echo "::error::Deprecation warning missing from quarto update chromium output"
117+
exit 1
118+
fi
119+
echo "Update deprecation warning found"
116120
117121
- name: Verify quarto check warns about outdated Chromium
118-
if: steps.install-chromium.outputs.chromium-installed == 'true'
119122
shell: bash
120123
run: |
124+
if [ "${{ steps.install-chromium.outputs.chromium-installed }}" != "true" ]; then
125+
echo "Chromium install did not succeed on this platform, skipping check"
126+
exit 0
127+
fi
121128
output=$(quarto check install 2>&1)
122129
echo "$output"
123130
if ! echo "$output" | grep -Fq "Chromium is outdated"; then
124131
echo "::error::Outdated Chromium warning missing from quarto check"
125132
exit 1
126133
fi
134+
echo "Outdated Chromium warning found in quarto check"

0 commit comments

Comments
 (0)