fix: normalize falsy logo spec to undefined in fillLogoPaths

gordonwoodhull · gordonwoodhull · commit dc19d5ac0f68 · 2026-03-05T12:53:41.000-05:00
Now that logo-light-dark-specifier-path-optional accepts `false`,
return `undefined` explicitly for all falsy values rather than
leaking `false` through to resolveLogo.
diff --git a/src/core/brand/brand.ts b/src/core/brand/brand.ts
@@ -505,7 +505,10 @@ export function fillLogoPaths(
     }
     return undefined;
   }
-  if (!spec || typeof spec === "string") {
+  if (!spec) {
+    return undefined;
+  }
+  if (typeof spec === "string") {
     return spec;
   }
   if ("light" in spec || "dark" in spec) {

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,10 @@ export function fillLogoPaths(`
`505`	`505`	`}`
`506`	`506`	`return undefined;`
`507`	`507`	`}`
`508`		`- if (!spec \|\| typeof spec === "string") {`
	`508`	`+ if (!spec) {`
	`509`	`+ return undefined;`
	`510`	`+ }`
	`511`	`+ if (typeof spec === "string") {`
`509`	`512`	`return spec;`
`510`	`513`	`}`
`511`	`514`	`if ("light" in spec \|\| "dark" in spec) {`