catch exception when directory contents change mid-traversal (#14342)

Author: cscheid

news/changelog-1.10.md

@@ -40,4 +40,4 @@ All changes included in 1.10:
 
 - ([#6651](https://github.com/quarto-dev/quarto-cli/issues/6651)): Fix dart-sass compilation failing in enterprise environments where `.bat` files are blocked by group policy.
 - ([#14255](https://github.com/quarto-dev/quarto-cli/issues/14255)): Fix shortcodes inside inline and display math expressions not being resolved.
-
+- ([#14342](https://github.com/quarto-dev/quarto-cli/issues/14342)): Work around TOCTOU race in Deno's `expandGlobSync` that can cause unexpected exceptions to be raised while traversing directories during project initialization.

src/core/path.ts

@@ -172,13 +172,23 @@ export function resolvePathGlobs(
   const expandGlobs = (targetGlobs: string[]) => {
     const expanded: string[] = [];
     for (const glob of targetGlobs) {
-      for (
-        const file of expandGlobSync(
-          glob,
-          { root, exclude, includeDirs: true, extended: true, globstar: true },
-        )
-      ) {
-        expanded.push(file.path);
+      try {
+        for (
+          const file of expandGlobSync(
+            glob,
+            { root, exclude, includeDirs: true, extended: true, globstar: true },
+          )
+        ) {
+          expanded.push(file.path);
+        }
+      } catch (e) {
+        // expandGlobSync can throw NotFound if a file is deleted between
+        // directory listing and stat (TOCTOU race). This is expected during
+        // preview when the IDE or other processes modify the project
+        // directory concurrently.
+        if (!(e instanceof Deno.errors.NotFound)) {
+          throw e;
+        }
       }
     }
     return ld.uniq(expanded);