Problematic height=\textheight in \includegraphics when #| out-width only is fixed

[EricMarcon]

Bug description

As mentioned in #2417,

---
title: "Untitled"
format: latex
keep-md: true
---

```{r}
#| label: main-plot
#| out-width: 50%
plot(mtcars)
```

generates the following in LaTeX (as of version 1.2.335, RStudio 2022.12.0 on Windows 11):

\includegraphics[width=0.5\textwidth,height=\textheight]{test_files/figure-latex/main-plot-1.pdf}

In a 2-column document, the figure is not formated as expected: it is wider than its column.

In R Markdown, the same options generated

\includegraphics[width=0.5\textwidth]{test_files/figure-latex/main-plot-1.pdf}

which worked perfectly.

A temporary workaround is to divide the desired width by 2.

So I think height=\textheight should not be added if #| out-height: is not specified in the Quarto file: LaTeX does not need it and it does not allow correct format in 2-column documents.

Thanks!

[cscheid]

It looks like there's (at least!) two things happening.

1. It seems that we shouldn't be outputting ,height=\textheight when only textwidth is specified (although I don't know if this is doing damage)
2. It seems that we should be outputting linewidth instead of textwidth anyway, since that is affected by two-column modes (and other contextual changes).

I don't want to introduce a subtle change like this late into our 1.3 prerelease, but we'll definitely make sure this works correctly.

[cderv]

For context about this, this is added by Pandoc . Intermediate .md before conversion gets

![](test2_files/figure-latex/main-plot-1.pdf){width=50%}

and Pandoc converts to TeX adding the units

\includegraphics[width=0.5\textwidth,height=\textheight]{test2_files/figure-latex/main-plot-1.pdf}

This is on purpose and they explain the Why in there FAQ item
https://pandoc.org/faqs.html#when-i-specify-an-image-width-of-50-and-convert-to-latex-pandoc-sets-the-height-to-textheight-and-the-aspect-ratio-isnt-preserved.-how-can-i-prevent-this

In knitr, for LaTeX, we handle the figure syntax creation in hook_plot_tex() and we create the units based in width and height provided (by fixing options for LaTeX)

That is why you see a different behavior with R Markdown @EricMarcon

In Quarto we unfix the option for the processing

quarto-cli/src/resources/rmd/hooks.R

Lines 468 to 471 in 2f3507a

	# knitr::fix_options will convert out.width and out.height to their
	# latex equivalents, reverse this transformation so our figure layout
	# code can deal directly with percentages
	options <- latex_sizes_to_percent(options)

and we let Pandoc do the figure syntax conversion from Markdow syntax

quarto-cli/src/resources/rmd/hooks.R

Lines 580 to 581 in 2f3507a

	# generate markdown for image
	md <- sprintf("%s", figure_cap(options), x, attr)

Something to look into considering all this context then.

Hope it helps

[cderv]

Before trying to take over Pandoc generation of the LaTeX for a figure, I want to understand better what is not working.
It seems to be an issue for you in a two column layout only.

In a 2-column document, the figure is not formated as expected: it is wider than its column.

Can you share an example of this ?

I get this in a single column document

And this with a twocolumn class option

Code

---
title: "Untitled"
format: pdf
classoption: twocolumn
keep-md: true
---

```{r}
#| label: main-plot
#| out-width: 50%
plot(mtcars)
```

And with text in the middle (using https://github.com/dragonstyle/lipsum)

---
title: "Untitled"
format: pdf
classoption: twocolumn
keep-md: true
---

{{< lipsum 7 >}}

```{r}
#| label: main-plot
#| out-width: 50%
plot(mtcars)
```

{{< lipsum 7 >}}

It seems ok to me.

What is your expected results exactly ?

It would help us having more details and an example of what is not working as expected exactly.

Thanks.

[cderv]

@EricMarcon Is this still an issue for you ? thanks !