A few changes for Deno 2 runtime compatibility#11351
Merged
cscheid merged 7 commits intoquarto-dev:mainfrom Dec 2, 2024
Merged
A few changes for Deno 2 runtime compatibility#11351cscheid merged 7 commits intoquarto-dev:mainfrom
cscheid merged 7 commits intoquarto-dev:mainfrom
Conversation
This API has been removed without replacement in Deno 2.
Contributor
Author
|
Regarding the contributor agreement form, what goes in the "fascimile" field? |
Member
A fax number if your company has one - no entry otherwise. |
Contributor
Author
|
I sent over my signed contributor agreement form. Sorry for the delay. |
Member
|
Thanks. Can you comment on the |
Contributor
Author
|
Sure. As far as I can tell, it was removed without replacement in Deno 2 and first deprecated by denoland/deno#20684. It sounds like maintaining it was deemed too difficult. Beyond that, I don't have any more information. |
Member
|
That's unfortunate - we were using that to check for stray unresolved promises. Ok, this looks good, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves a few method calls that were deprecated and removed in Deno 2 to their replacements (except for
Deno.metrics(), which was removed without replacement).This is not a complete set of changes: some dependencies also need to be updated or patched (xmlp is the main one that I'm aware of right now), but testing the waters here with this smaller and simpler one since this is my first contribution.
Checklist
I have (if applicable):