avoid cryptic error message because of internal function not handling null value#12372
Merged
avoid cryptic error message because of internal function not handling null value#12372
Conversation
… null value There could be a null value of someone does ```` format: html: null ```` or ```` format: html: ```` This is caught by YAML validation, but validation of YAML could happen after format resolution.
Member
|
That is a good, if very strange fix for the error! I will just add a comment pointing here, and then we can close the issue. |
Member
Author
|
Great. I wanted to discuss this and forgot last week. Very strange fix indeed but definitely solves the problem. We can still discuss this validation order even after merge. Thanks for having look into it ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There could be a null value of someone does
or
This is caught by YAML validation, but validation of YAML could happen after format resolution.
fixes #12369
With this PR I correctly get now for
quarto previewIs this the best way to solve #12369 ? IDK but it seems an ok fix to protect against some value that
fixupMergeableScalarsdoes not handle