Feature: brand-mode to choose light or dark brand in Typst#12387
Merged
gordonwoodhull merged 2 commits intomainfrom Apr 1, 2025
Merged
Feature: brand-mode to choose light or dark brand in Typst#12387gordonwoodhull merged 2 commits intomainfrom
brand-mode to choose light or dark brand in Typst#12387gordonwoodhull merged 2 commits intomainfrom
Conversation
07f0173 to
90cc79f
Compare
cscheid
previously requested changes
Mar 27, 2025
Member
cscheid
left a comment
There was a problem hiding this comment.
LGTM aside from the schema name.
brand-mode to choose light or dark brand in Typst
90cc79f to
0b6c052
Compare
0b6c052 to
df01c7f
Compare
Member
Author
|
Note: this doesn't consider author preference, i.e. if Since we are moving away from author preference online #12426, this seems less urgent. But it could in theory be initialized from TS in the Quarto front-end. Order of YAML objects is unavailable in Lua metadata! 😮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised, this turned out to be quite simple once everything else was in place.
Filing as draft because
this needs a better name thanchoose-brandtypst_css.luawhere it needs access tochoose-brandinstead of hard-codedbrandMode = 'light'Cases like
quarto-cli/tests/docs/smoke-all/typst/brand-yaml/color/typst-css-named-brand-color.qmd
Lines 26 to 28 in 5df4e19