do not emit dark stylesheets when there is no dark brand#12400
Merged
gordonwoodhull merged 1 commit intomainfrom Mar 28, 2025
Merged
do not emit dark stylesheets when there is no dark brand#12400gordonwoodhull merged 1 commit intomainfrom
gordonwoodhull merged 1 commit intomainfrom
Conversation
properly handle absent light or dark brand do not emit empty light/dark brand bundles
cderv
reviewed
Mar 28, 2025
gordonwoodhull
added a commit
that referenced
this pull request
Apr 7, 2025
these implicitly create a light theme as well and will include two stylesheets ref #12400
gordonwoodhull
added a commit
that referenced
this pull request
Apr 7, 2025
these implicitly create a light theme as well and will include two stylesheets ref #12400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle absent light or dark brand; do not emit empty light/dark brand bundles.
This fixes the syntax highlighting issue we were seeing. (But note the issue can still be seen with arrow syntax highlighting when JavaScript is disabled; see #12399.)