Skip to content

publish - timeout after 5 minutes#12418

Merged
cscheid merged 1 commit intomainfrom
bugfix/12286
Apr 1, 2025
Merged

publish - timeout after 5 minutes#12418
cscheid merged 1 commit intomainfrom
bugfix/12286

Conversation

@cscheid
Copy link
Copy Markdown
Member

@cscheid cscheid commented Mar 31, 2025

Closes #12286.

@cwickham: I don't want to add a test for this, because it will be a relatively obnoxious thing to run every time. Would you mind verifying that this does what you expect in your setup? Thanks.

@cscheid cscheid merged commit a61b2f9 into main Apr 1, 2025
49 checks passed
@cscheid cscheid deleted the bugfix/12286 branch April 1, 2025 14:54
@cwickham
Copy link
Copy Markdown
Member

cwickham commented Apr 1, 2025

It seems to work OK, but the messages are confusing:

NOTE: GitHub Pages sites use caching so you might need to click the refresh
button within your web browser to see changes after deployment.

(/) Deploying gh-pages branch to website (this may take a few minutes)Deployment took longer than 5 minutes, giving up waiting for deployment to complete
[✓] Deploying gh-pages branch to website (this may take a few minutes)
[✓] Published to https://cwickham.github.io/gh-pages-test/

NOTE: GitHub Pages deployments normally take a few minutes (your site updates
will be visible once the deploy completes)
  • The message should probably be on its own line.
  • Why is Deploying gh-pages branch to website (this may take a few minutes) repeated?
  • This shouldn't be a check mark [✓] Published to https://cwickham.github.io/gh-pages-test/. Maybe a ? is appropriate in this instance?

@cderv
Copy link
Copy Markdown
Member

cderv commented Apr 2, 2025

It is happening because code runs in a withSpinner()

So the info() call interleaves the message in the spinner one.

And then

completeMessage(`Published to ${ghContext.siteUrl || ghContext.originUrl}`);

is not conditional to the timeout.

So we could improve this. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quarto publish gh-pages should timeout eventually

3 participants