Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/changelog-1.7.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ All changes included in 1.7:
- ([#11659](https://github.com/quarto-dev/quarto-cli/pull/11659)): `julia` engine - Fix escaping bug where paths containing spaces or backslashes break server startup on Windows.
- ([#11752](https://github.com/quarto-dev/quarto-cli/issues/11752)): Fix regression with non-alphanumeric characters in `categories` preventing correct filtering of listing.
- ([#11943](https://github.com/quarto-dev/quarto-cli/issues/11943)): Fix callout title color on dark theme in revealjs following Revealjs update in quarto 1.6.
- ([#11990](https://github.com/quarto-dev/quarto-cli/issues/11990)): Do not print parameter cell in parameterized Jupyter notebooks.
- ([#12147](https://github.com/quarto-dev/quarto-cli/issues/12147)): for RevealJS format, `serif` and `simple` themes defaults back to have their heading color (`$presentation-heading-color`) to be the same as the body color (`$body-color`) as in Quarto 1.5.

## Dependencies
Expand Down
4 changes: 3 additions & 1 deletion src/resources/jupyter/notebook.py
Original file line number Diff line number Diff line change
Expand Up @@ -686,9 +686,11 @@ def nb_parameterize(nb, params):
# and then re-encode it
try:
params_cell_yaml = parse_string("\n".join(params_cell_yaml))
del params_cell_yaml['label']
if "label" in params_cell_yaml:
del params_cell_yaml['label']
params_cell_yaml = safe_dump(params_cell_yaml).strip().splitlines()
except Exception as e:
sys.stderr.write(str(e) + "\naksjdfhakjsdhf\n")
sys.stderr.write("\nWARNING: Invalid YAML option format in cell:\n" + "\n".join(params_cell_yaml) + "\n")
sys.stderr.flush()
params_cell_yaml = []
Expand Down
18 changes: 18 additions & 0 deletions tests/docs/jupyter/parameters/issue-11990.qmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
title: "Quarto Parameters"
format: html
engine: jupyter
keep-md: true
keep-ipynb: true
---

```{python}
#| tags: [parameters]
#| include: false
username = None
password = None
```

```{python}
print(f"Hello, {username}!")
```
23 changes: 23 additions & 0 deletions tests/smoke/jupyter/issue-11990.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/*
* issue-11990.test.ts
*
* https://github.com/quarto-dev/quarto-cli/issues/11990
*
* Copyright (C) 2025 Posit Software, PBC
*/

import { join } from "../../../src/deno_ral/path.ts";
import { docs, outputForInput } from "../../utils.ts";
import { noErrorsOrWarnings, ensureFileRegexMatches } from "../../verify.ts";
import { testRender } from "../render/render.ts";

const format = "html";
const input = docs(join("jupyter", "parameters", "issue-11990.qmd"));
const output = outputForInput(input, format);

testRender(input, format, false, [
noErrorsOrWarnings,
ensureFileRegexMatches(output.outputPath, [], [
"Injected Parameters"
]),
], {}, ["--no-execute-daemon", "--execute-param", "username:John"]);
Loading