preview - don't set options as a const to avoid conflict with Global Scope#12517
Merged
preview - don't set options as a const to avoid conflict with Global Scope#12517
Conversation
Member
Author
|
I added a way to get the preview options if needed ---
title: "my board"
format: html
engine: knitr
---
# content
```{js}
//| echo: false
document.addEventListener("quarto-preview-initialized", function(e) {
const pElement = document.createElement("p");
const codeElement = document.createElement("code")
codeElement.textContent = JSON.stringify(e.detail);
pElement.appendChild(codeElement)
document.querySelector("#content").appendChild(pElement);
})
```
|
Member
|
Yeah, this is fine. (Essentially no one should be writing to the global scope, libraries or us.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #12513
Currently
quarto previewscript will defineconstthat is available in Global scope in the previewed HTMLquarto-cli/src/resources/preview/quarto-preview.html
Lines 6 to 14 in 73805d3
Here is an example of the options being seen in JS
It does not seem like a good thing that is defined globally and impact any JS script.
This PR is here as a draft to discuss this idea.
I don't know if some other tools can rely on these generic
optionsbeing available. Hopefully not because it could be redefined too. If this should be made available, it should probably be namespaced.