Bugfix: disable light highlight stylesheet#12538
Closed
gordonwoodhull wants to merge 3 commits intomainfrom
Closed
Bugfix: disable light highlight stylesheet#12538gordonwoodhull wants to merge 3 commits intomainfrom
gordonwoodhull wants to merge 3 commits intomainfrom
Conversation
these test some elements we saw bad behavior in nojs mode also, a rather more severe bug where light highlighting is being applied
Member
Author
|
Closed in favor of #12523 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #12523
It also fixes the highlight style bleed issues, but it fixes the big dark mode syntax highlighting bug a different way, by disabling the light highlight stylesheet when in dark mode.
This is arguably simpler, but it's not how our highlight stylesheets worked in 1.6, where dark = light + dark for highlight stylesheets as well. So it is less conservative.
Although I could detect no difference in dark mode syntax highlighting between the two PRs, and the other has uglier code, I favor the other one.
fixes #12399
fixes #12522