bugfix: giscus light dark author pref base alt semantics#12608
Closed
gordonwoodhull wants to merge 3 commits intomainfrom
Closed
bugfix: giscus light dark author pref base alt semantics#12608gordonwoodhull wants to merge 3 commits intomainfrom
gordonwoodhull wants to merge 3 commits intomainfrom
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
gordonwoodhull
deleted the
bugfix/giscus-light-dark-author-pref-base-alt-semantics
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Giscus light/dark issue by continuing down the road of #11047 and #12567 and getting it to work.
Most of the issues were caused by the new ambiguity between the author preference and the user preference.
I hope we don't have to merge this, but this is fully tested across author preference, user preference, and
respect-user-color-scheme.I'm going to try a simpler fix against #12570, which instead removes #11047 (the mutation observer and dynamic loading of the giscus script).
Submitting this as draft in case the simpler solution doesn't succeed.