style: sun/moon toggle for light/dark mode#12610
Closed
mcanouil wants to merge 1 commit intoquarto-dev:mainfrom
Closed
style: sun/moon toggle for light/dark mode#12610mcanouil wants to merge 1 commit intoquarto-dev:mainfrom
mcanouil wants to merge 1 commit intoquarto-dev:mainfrom
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Member
|
I'm not merging a PR with an astronomically-impossible crescent, sorry :) |
Collaborator
Author
|
I would be more concerned about the actual accessibility status of the toggle button 😅 |
Collaborator
Author
|
FWIW, I've changed the CSS for my Quarto extensions listing (+ light/dark mode): https://m.canouil.dev/quarto-extensions/ |
Member
|
I'm going to close this, but FYI later on in 1.8 we're going to switch to the same animation as the Shiny team uses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the basic toggle for light/dark with a sun and moon toggle.
Screen.Recording.2025-04-24.at.00.01.40.mov