Merged
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Member
|
(Your PR didn't actually change |
cderv
commented
May 6, 2025
Comment on lines
+9
to
+11
| # file with cell magic not parsed by ruff | ||
| "src/resources/jupyter/lang/python/cleanup.py", | ||
| "src/resources/jupyter/lang/python/setup.py", |
Member
Author
There was a problem hiding this comment.
@cscheid we already don't process those files as they don't play well with ruff as you guessed. This why they are not formatted in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new PR for #12446
This PR complements the one for R
Ruff VSCODE extension is now configuredto format all
*.py*.ipynbare skipped because of#|to# |change for cell options.configuration is done on
.ruff.tomlso thatruffworks on CLI too.