fix bad directory relocation fallback code#12782
Merged
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
cderv
approved these changes
May 20, 2025
Member
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Looks like a bad bug.
Thanks for finding that. It looks ok to me.
I agree it is hard to test.
Closed
Member
Author
|
Thanks for reviewing. Yeah, we had two real bugs because of the bad documentation in Deno's isSubdir. I've added a unit test to the other one since it's much easier to. |
gordonwoodhull
approved these changes
May 20, 2025
Member
gordonwoodhull
left a comment
gordonwoodhull
left a comment
There was a problem hiding this comment.
Sure looks like a typo in rare fallback case, argh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo on fallback code for directory relocation. This is hard to test because it gets executed only in an exception handler in strange circumstances.