lua - use pandoc APIs for codepage handling#12806
Merged
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
cderv
reviewed
May 23, 2025
| return leaf | ||
| end | ||
| assert((CS1 - CS2) % width == offset) | ||
| if pandoc.system.os == "windows" then |
Member
There was a problem hiding this comment.
This is wrong
See https://pandoc.org/lua-filters.html#pandoc.system.os
The operating system on which the program is running. (string) The most common values are darwin (macOS), freebsd, linux, linux-android, mingw32 (Windows), netbsd, openbsd.
Windows is mingw32
❯ pandoc lua
Lua 5.4.7 Copyright (C) 1994-2024 Lua.org, PUC-Rio
Embedded in pandoc 3.7.0.1 Copyright (C) 2006-2024 John MacFarlane
> pandoc.system.os
mingw32
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 3.0, Pandoc has had the ability to do codepage conversions, so we don't need to use the pure-Lua hacks we currently have.