feat: Add support for YouTube Shorts in video shortcode#12811
feat: Add support for YouTube Shorts in video shortcode#12811cscheid merged 6 commits intoquarto-dev:mainfrom
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
The dropbox video was deleted: https://github.com/quarto-dev/quarto-cli/blob/main/tests/docs/smoke-all/video/video-smoke-test.qmd#L48 It seems the tests are not good as they don't catch issues with videos. |
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Awesome thanks !
The dropbox video was deleted:
main/tests/docs/smoke-all/video/video-smoke-test.qmd#L48It seems the tests are not good as they don't catch issues with videos.
About thus, I agree this is not ideal.
Though the tests are primarly there to check that our Lua filter to create the right syntax with video.js
They are not there to test that the resources are working. We could consider that even with a non working dropbox video link, the test is still valid because we are creating the correct HTML content from the video shortcode. The video not working is another issue; I wouldn't this Lua filter video shortcode test to fail because of that.
It is probably also hard to check as the link does not return 404.
This would probably require playwright, and check that video.js can load the file. 🤷
This would be a good integration test to detect early that somehow video.js is not working as expected, or that video is no more there.
Did you have another idea ?
Not really, I was mentioning it as I noticed the video was gone when adding the new test. |
Ok, I don't know which video it was - so not sure if there is another one we could use that will stay 🤔 |
|
Looks great, thank you! |
4 participants
Introduce support for YouTube Shorts in the video shortcode to enhance video embedding capabilities. This change allows users to include YouTube Shorts links seamlessly.