Skip to content

feat: Add support for YouTube Shorts in video shortcode #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cscheid merged 6 commits into from
May 23, 2025
Merged

feat: Add support for YouTube Shorts in video shortcode #12811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
217a27b
feat: add youtube short support for video shortcode
mcanouil May 23, 2025
878cab3
chore: add changelog entry
mcanouil May 23, 2025
97ed204
style: use inline code
mcanouil May 23, 2025
62b762a
test: add "shorts" to test file
mcanouil May 23, 2025
c332ff3
fix: full URL
mcanouil May 23, 2025
4259d85
test: update regex
mcanouil May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion news/changelog-1.8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ All changes included in 1.8:

- ([#12727](https://github.com/quarto-dev/quarto-cli/issues/12727)): Do not crash in the presence of malformed tabset contents.
- ([#12806](https://github.com/quarto-dev/quarto-cli/pull/12806)): Use pandoc APIs to handle codepage conversion on Windows.
- ([#12811](https://github.com/quarto-dev/quarto-cli/pull/12811)): Add support for YouTube Shorts in `video` shortcode.

## Commands

Expand All @@ -63,4 +64,4 @@ All changes included in 1.8:
## Other fixes and improvements

- ([#11321](https://github.com/quarto-dev/quarto-cli/issues/11321)): Follow [recommendation from LaTeX project](https://latex-project.org/news/latex2e-news/ltnews40.pdf) and use `lualatex` instead of `xelatex` as the default PDF engine.
- ([#12782](https://github.com/quarto-dev/quarto-cli/pull/12782)): fix bug on `safeRemoveDirSync`'s detection of safe directory boundaries.
- ([#12782](https://github.com/quarto-dev/quarto-cli/pull/12782)): fix bug on `safeRemoveDirSync`'s detection of safe directory boundaries.
1 change: 1 addition & 0 deletions src/resources/extensions/quarto/video/video.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ local youTubeBuilder = function(params)
if not (params and params.src) then return nil end
local src = params.src
match = checkMatchStart(src, 'https://www.youtube.com/embed/')
match = match or checkMatchStart(src, 'https://www.youtube.com/shorts/')
match = match or checkMatchStart(src, 'https://www.youtube%-nocookie.com/embed/')
match = match or checkMatchStart(src, 'https://youtu.be/')
match = match or string.match(src, '%?v=(.-)&')
Expand Down
9 changes: 9 additions & 0 deletions tests/docs/smoke-all/video/video-smoke-test.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ _quarto:

- '#brightcove-test iframe[src$="https://players.brightcove.net/1460825906/default_default/index.html?videoId=5988531335001"]'

- "#youtube-short-test .quarto-video.ratio.ratio-16x9"
- '#youtube-short-test iframe[src$="https://www.youtube.com/embed/Kra3uHSIuBY"]'

---

::: {#video-js-test}
Expand Down Expand Up @@ -106,3 +109,9 @@ _quarto:
{{< video https://players.brightcove.net/1460825906/default_default/index.html?videoId=5988531335001 >}}

:::

::: {#youtube-short-test}

{{< video https://www.youtube.com/shorts/Kra3uHSIuBY >}}

:::
Loading